Repository navigation
BaseCluster: initialise errors to 0 by default - #15988
Merged
Merged
Conversation
o2::BaseCluster default constructor leaves mSigmaYZ uninitialised, so with addPVAsCluster the PV cluster entered the refit with a garbage YZ covariance term, making the residuals non-reproducible between identical runs.
shahor02
reviewed
Oct 20, 2026
shahor02
left a comment
shahor02
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, but I think it is better to init to 0 by default Base cluster errors.
Following review: rather than setting sigmaYZ explicitly in CheckResid, zero-initialise mSigmaY2/mSigmaZ2/mSigmaYZ in BaseCluster so that default-constructed clusters (e.g. the PV pseudo-cluster in CheckResid) never carry uninitialised error terms.
hyungjun-lee
changed the title
Contributor
Author
|
@shahor02, |
shahor02
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated following review: errors are now zero-initialised in
BaseClusteritself instead of setting sigmaYZ in CheckResid.o2::BaseCluster<float>has a defaulted constructor, somSigmaYZis left uninitialised. InCheckResidSpec::processITSTrack, withaddPVAsClusterenabled, the PV pseudo-clusterbcPVsets X/Y/Z,sigmaY2,sigmaZ2and the sensor ID but neversigmaYZ. The PV then enters the refit with an arbitrary YZ covariance term taken from the stack.Default member initialisers only: no change to the data layout (ClassDef version kept), configuration or output format.