Repository navigation
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ctrl+Alt+Shotkey so screenshot capture works while the game owns keyboard focuscaptureGameWindowimplementation without revealing the VS Code asset panel first, so a normal configured capture does not pull focus away from the gameRegisterHotKeyfailures with bounded backoff and stop the helper with the VS Code extension hostscreenshotToTemplatekeybinding/command unchanged as the normal in-IDE path and local fallbackCross-host scope
JetBrains parity is implemented in AliceJump/ok-script-toolkit-jetbrains#33. This PR remains draft until that child PR is reviewed and squash-merged, then the parent
jetbrainsgitlink will be advanced to the merged child commit before this PR is marked ready.Validation
da4914e1e144301b7e3902e83504d20d8a849c4c: compile, full tests, localization checks, and VSIX packaging passjetbrainsgitlink: it checks out child0fb95a0, whosePythonScriptLocatorpredates the new sharedglobal_hotkey.py; updating the gitlink after child merge is the required prerequisite rather than a flaky rerun