Skip to content

feat: add global screenshot hotkey - #40

Closed
AliceJump wants to merge 10 commits into
mainfrom
codex/global-screenshot-hotkey
Closed

AliceJump wants to merge 10 commits into
mainfrom
codex/global-screenshot-hotkey

Conversation

@AliceJump

@AliceJump AliceJump commented Oct 9, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • register a Windows system-wide Ctrl+Alt+S hotkey so screenshot capture works while the game owns keyboard focus
  • route the global trigger through the existing captureGameWindow implementation without revealing the VS Code asset panel first, so a normal configured capture does not pull focus away from the game
  • retry temporary RegisterHotKey failures with bounded backoff and stop the helper with the VS Code extension host
  • keep the existing VS Code screenshotToTemplate keybinding/command unchanged as the normal in-IDE path and local fallback

Cross-host scope

JetBrains parity is implemented in AliceJump/ok-script-toolkit-jetbrains#33. This PR remains draft until that child PR is reviewed and squash-merged, then the parent jetbrains gitlink will be advanced to the merged child commit before this PR is marked ready.

Validation

  • current VS Code HEAD da4914e1e144301b7e3902e83504d20d8a849c4c: compile, full tests, localization checks, and VSIX packaging pass
  • the parent JetBrains aggregate job is intentionally blocked by the old jetbrains gitlink: it checks out child 0fb95a0, whose PythonScriptLocator predates the new shared global_hotkey.py; updating the gitlink after child merge is the required prerequisite rather than a flaky rerun
  • branch diff contains only the shared hotkey helper and VS Code global/background capture entry points; the gitlink update will be added after child merge

@coderabbitai

coderabbitai Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@AliceJump

Copy link
Copy Markdown
Owner Author

已整合到 #42,保留全局后台截图及注册重试,并新增重复触发、唯一文件名和失败恢复回归;后续审阅与合并在 #42 统一完成。

@AliceJump AliceJump closed this Oct 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant