Rescue#6
Draft
Al-Kindi-0 wants to merge 4 commits into
Draft
Conversation
bobbinth
requested changes
Jul 1, 2022
bobbinth
left a comment
bobbinth
left a comment
Collaborator
There was a problem hiding this comment.
Looks good! Just a couple of small comments inline.
| ]; | ||
|
|
||
| assert_eq!(expected, state); | ||
| assert_eq!(expected[0], state[0]); |
Collaborator
There was a problem hiding this comment.
Is there a reason we assert equality only for the first elements of the state?
| // MDS | ||
| // ================================================================================================ | ||
| /// Rescue MDS matrix | ||
| /// Computed using algorithm 4 from <https://eprint.iacr.org/2020/1143.pdf> |
Collaborator
There was a problem hiding this comment.
It would probably be good to add a very brief explanation (1 - 2 sentences) about this MDS matrix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rescue optimization