Mont 64#1
Open
Al-Kindi-0 wants to merge 15 commits into
Open
Conversation
bobbinth
requested changes
Jun 13, 2022
bobbinth
left a comment
bobbinth
left a comment
Collaborator
There was a problem hiding this comment.
Thank you! Looks good. I left a bunch of small comments inline.
bobbinth
requested changes
Jun 14, 2022
bobbinth
left a comment
bobbinth
left a comment
Collaborator
There was a problem hiding this comment.
Looks good! I left a few more nits inline.
One other thing - let's move msquare() and equals() into helper function sections. Unless there is a need to expose them in the public interface.
bobbinth
requested changes
Jun 14, 2022
bobbinth
left a comment
bobbinth
left a comment
Collaborator
There was a problem hiding this comment.
Looks great! I left a couple of minor nits inline.
I think the last thing left is to make sure serialization tests pass as well.
bobbinth
requested changes
Jun 16, 2022
bobbinth
left a comment
bobbinth
left a comment
Collaborator
There was a problem hiding this comment.
Looks good! I left a few small nits inline. Also, I think a comment on line 18 needs to be updated.
This reverts commit f1b7cef.
Al-Kindi-0
force-pushed
the
main
branch
2 times, most recently
from
2496f01 to
eea409c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First PR