feat: claim rewards from compound by frazarshad · Pull Request #12707 · Agoric/agoric-sdk

frazarshad · 2026-06-04T14:14:01Z

closes: https://linear.app/agoric/issue/PAK-432/ymax-contract-should-be-able-to-claim-reward-tokens-on-compound

Description

Adds claim rewards functionality to compound.
removes the claim param from the withdraw function and instead uses it to trigger the claimRewards function. so now to trigger claiming rewards for compound, a step like this would be used:

  {
            dest: '@Arbitrum',
            src: 'Compound_Arbitrum',
            amount: emptyAmount,
            fee: feeCall,
            claim: true,
   },

Testing Considerations

unit tests have been added, but e2e testing has not been performed, since that can only be done in a mainnet environment

Upgrade Considerations

redepolyment of ymax contract is required for this feature

dckc

a couple points I'm not clear on...

dckc · 2026-06-04T14:19:16Z

+    const { addresses: a } = ctx;
+    const session = makeEvmAbiCallBatch();
+    const compoundRewardsController = session.makeContract(
+      a.compoundRewardsController,


Upgrade Considerations

this adds new addresses to the axelar-config, so redepolyment of ymax contract is required with new args

I don't see any changes in axelar-config.

these contracts were already implemented in the withdraw function. The original behaviour was that rewards claiming could be triggered during a withdraw by adding a claim flag.

Now this functionality has been moved seperately under the claimRewards function

I guess that means the Upgrade Considerations should change?

updated. thanks for pointing it out

dckc · 2026-06-04T14:21:09Z

  ]);
 });
+
+test('claim rewards from Compound position', async t => {


Testing Considerations

unit tests have been added, but e2e testing has not been performed, since that can only be done in a mainnet environment

a feat usually comes with a contract-level test.

adding 👍

dckc

I'd like to understand the UX better.

dckc · 2026-06-08T17:12:13Z

+  const rebalanceP = trader1.rebalance(
+    t,
+    { give: { Deposit: amount }, want: {} },
+    {
+      flow: [
+        {
+          dest: '@Arbitrum',
+          src: 'Compound_Arbitrum',
+          amount: usdc.make(100n),
+          fee: feeCall,
+          claim: true,
+        },
+      ],
+    },
+  );


the trader interface is supposed to be an example of what a front end might use.

Is this how we expect the claim UX to work? It involves a deposit too?

The only story about non-auto claiming is for an internal user way to manually trigger (as documented in https://linear.app/agoric/issue/AGO-652/let-internal-user-manually-trigger-claim-rewards). Until that is implemented, it is acceptable to just create a rebalance flow, and submit steps that the planner would create if it had identified/created a rewards claim flow.

That said I would not expect to see a deposit amount in a reblance (pretty sure the contract actually drops those)

dckc · 2026-06-08T17:15:04Z

 });
+
+test('claim rewards on Compound position successfully', async t => {
+  const { trader1, common, txResolver } = await setupTrader(t);


Do we mostly expect this to be used via EVM? Is it straightforward to do an evm trader test?

It's unclear whether internal user tests would be able to manually trigger rewards claiming through evm wallets. That said it should be possible to write a test where the test planner submits rewards steps.

mhofman · 2026-06-08T18:20:22Z

+      /** Discriminant: claim flag routes the step to claimRewards. */
+      claim: true;


Should this move to the "base" PR?

frazarshad requested review from AliRehman1279, Muneeb147, dckc and rabi-siddique June 4, 2026 14:14

dckc reviewed Jun 4, 2026

View reviewed changes

frazarshad requested a review from dckc June 5, 2026 15:35

dckc removed their request for review June 5, 2026 16:20

rabi-siddique approved these changes Jun 8, 2026

View reviewed changes

dckc reviewed Jun 8, 2026

View reviewed changes

mhofman reviewed Jun 8, 2026

View reviewed changes

frazarshad force-pushed the fraz/claim-rewards-morpho branch from 8b391af to 6ec75f2 Compare June 9, 2026 14:57

frazarshad force-pushed the fraz/claim-rewards-compound branch from 1511c66 to 16047a9 Compare June 9, 2026 15:18

frazarshad changed the base branch from fraz/claim-rewards-morpho to fraz/claim-rewards-flow June 9, 2026 15:18

frazarshad added 4 commits June 9, 2026 17:38

feat: add claimRewards for compound

5e8f245

refactor: use claim flag to claim rewards

cf9c49a

test: contract level test for compound claimRewards

e595292

fixup! feat: add claimRewards for compound

ce1d8ea

frazarshad force-pushed the fraz/claim-rewards-compound branch from 16047a9 to ce1d8ea Compare June 9, 2026 15:40

frazarshad mentioned this pull request Jun 9, 2026

feat: create claim rewards step #12718

Open

		/** Discriminant: claim flag routes the step to claimRewards. */
		claim: true;

Conversation

frazarshad commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing Considerations

Upgrade Considerations

Uh oh!

dckc left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dckc left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

frazarshad commented Jun 4, 2026 •

edited

Loading