feat: add claim rewards functionality for morpho vaults

[frazarshad]

closes: https://linear.app/agoric/issue/PAK-431/ymax-contract-should-be-able-to-claim-reward-tokens-on-morpho

Description

Adds a new claimRewards function in the to the erc4626 morpho protocol which can be used to claim rewards for a users position on a chain

rewards can be claimed by a step similar to this to the flow:

  {
    dest: '@Ethereum',
    src: 'ERC4626_morphoGauntletUsdcRwa_Ethereum',
    amount: 0n,
    fee: feeCall,
    claim: true,
    claimParams: {
        users: ['0x0000000000000000000000000000000000000001'],
        tokens: ['0x0000000000000000000000000000000000000002']],
        amounts: [1_234_567n],
        proofs: [
          [
            '0x1111111111111111111111111111111111111111111111111111111111111111',
            '0x2222222222222222222222222222222222222222222222222222222222222222',
          ],
        ],
  }

where the claimParams can be obtained from the merkl api. An example API call is here

Testing Considerations

unit tests have been added, but e2e testing has not been performed, since that can only be done in a mainnet environment

Upgrade Considerations

this adds new addresses to the axelar-config, so redepolyment of ymax contract is required with new args

[dckc]

I just started looking at this, but I found one change worth making.

[dckc]

Upgrade Considerations

this adds new addresses to the axelar-config, so redepolyment of ymax contract is required with new args

Please update these to include the new args:

• privateArgs-ymax0.json
• privateArgs-ymax1.json

Odd... the tests for ymax1 contract addresses match golden snapshot and such in evm-overrides.test.ts should have triggered an update. I wonder why they didn't. Maybe because the new stuff is optional?

[dckc]

I'd have to understand the project better to approve.

But I'm withdrawing my request for changes.

[dckc]

Testing Considerations

unit tests have been added, but e2e testing has not been performed, since that can only be done in a mainnet environment

contract-level tests are closer to e2e. A feat usually comes with one or more. In particular, vstorage snapshots help to understand how the feature impacts the rest of the system.

addressed

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 462f5dad-50fe-4049-9c31-47c0089413fe

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fraz/claim-rewards-morpho

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}