Skip to content

chore(portfolio-deploy): make mainnet deployment more robust#12680

Draft
dckc wants to merge 7 commits into
masterfrom
dc-ymax-ops
Draft

chore(portfolio-deploy): make mainnet deployment more robust#12680
dckc wants to merge 7 commits into
masterfrom
dc-ymax-ops

Conversation

@dckc

@dckc dckc commented May 22, 2026

Copy link
Copy Markdown
Member

Description / Upgrade Considerations

  • fix namespace for main
  • KLUDGE around RPC load balancer
  • retry getGoodLogs
  • avoid swallowing errors / stack traces
  • adjust job preconditions

Security / Scaling / Documentation Considerations

n/a

Testing Considerations

https://github.com/Agoric/agoric-sdk/releases/tag/ymax-v0.3.2605-beta1 is an integration test
along with several runs up to https://github.com/Agoric/agoric-sdk/actions/runs/26269136326/job/77318699362

@dckc dckc requested review from LuqiPan and michaelfig May 22, 2026 05:07
@dckc dckc marked this pull request as ready for review May 22, 2026 05:09
@dckc dckc added the bypass:integration Prevent integration tests from running on PR label May 22, 2026
@dckc dckc requested a review from Muneeb147 May 22, 2026 14:20
Comment on lines +52 to +53
// KLUDGE! avoid flaky load-balanced setup
rpcAddrMainGood = 'https://rpc.agoric-main-eu1.ccvalidators.com:443',

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Muneeb147 and I agreed that /network-config should take care of providing a working RPC node.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes
Once SRE calls-out that main.agoric.net/network-config is providing stable rpcAddr, until then it's fine to use ccvalidators (as it's the same upstream which we use)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to you @dckc ?

@dckc dckc May 22, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm inclined to take this KLUDGE out before landing this PR.
If I see any more RPC trouble, I'll count on SRE to fix it by adjusting /network-config.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I second it.
Let's rely on /network-config which points to main.rpc.agoric.net rpcAddr.
I have checked it is healthy as expected.

image

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But do have retries while hitting this rpc? Incase of any intermittent failure response...

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dckc As per verification here:
https://linear.app/agoric/issue/PAK-441/verify-healthy-upstream-routing-for-mainrpcagoricnet#comment-22d67118

We can use main.rpc.agoric.net (we can rely on main.agoric.net/network-config)

@dckc dckc changed the title chore(portfolio-deploy): address mainnet deployment papercuts chore(portfolio-deploy): make mainnet deployment more robust May 22, 2026
@dckc dckc deployed to ymax0-devnet June 2, 2026 23:56 — with GitHub Actions Active
@dckc dckc deployed to ymax0-mainnet June 3, 2026 00:46 — with GitHub Actions Active
@dckc dckc marked this pull request as draft June 3, 2026 04:34
@socket-security

Copy link
Copy Markdown

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
License policy violation: npm @chain-registry/types under SEE LICENSE IN LICENSE

License: SEE LICENSE IN LICENSE - This license classifier is not allowed by the applicable policy (package/package.json)

From: ?npm/@chain-registry/client@1.47.4npm/@chain-registry/types@0.50.194

ℹ Read more on: This package | This alert | What is a license policy violation?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@chain-registry/types@0.50.194. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
License policy violation: npm @chain-registry/utils under SEE LICENSE IN LICENSE

License: SEE LICENSE IN LICENSE - This license classifier is not allowed by the applicable policy (package/package.json)

From: ?npm/@chain-registry/client@1.47.4npm/@chain-registry/utils@1.51.194

ℹ Read more on: This package | This alert | What is a license policy violation?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@chain-registry/utils@1.51.194. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
License policy violation: npm typescript under CC-BY-4.0

License: CC-BY-4.0 - The applicable license policy does not permit this license (5) (package/ThirdPartyNoticeText.txt)

License: MIT-Khronos-old - The applicable license policy does not permit this license (5) (package/ThirdPartyNoticeText.txt)

License: LicenseRef-W3C-Community-Final-Specification-Agreement - The applicable license policy does not permit this license (5) (package/ThirdPartyNoticeText.txt)

From: ?npm/@endo/bundle-source@4.1.2npm/typescript@5.7.3

ℹ Read more on: This package | This alert | What is a license policy violation?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/typescript@5.7.3. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bypass:integration Prevent integration tests from running on PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants