Repository navigation
fix: fail on hung encode, resume TUS uploads, fail-fast on video upload - #88
Merged
Merged
Conversation
Addresses PR #86 review round 2: - make_streamable_mp4 now raises on an ffmpeg timeout / exhausted encode budget instead of returning the unencoded original, which run_pipeline would otherwise upload as a non-playable processed.mp4 and mark the match done. - _upload_resumable resumes a TUS upload from the server's offset (via HEAD) after a transient chunk failure instead of restarting the session; the create step is retried and the whole upload stays within the 600s budget. - upload_results_parallel blocks on the mandatory video first and shuts the pool down without waiting, so a video failure (e.g. 413) is not delayed by optional heatmap retries burning their budget. Adds tests for the encode-timeout raise and the video fail-fast behavior (9 pass).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses PR #86 review round 2:
Adds tests for the encode-timeout raise and the video fail-fast behavior (9 pass).