Repository navigation
fix: bound encode/upload deadlines and classify SDK 4xx as permanent - #87
Merged
Merged
Conversation
Addresses PR #86 review comments: - make_streamable_mp4 shares one encode deadline across both codec attempts, so a hung nvenc followed by a hung libx264 can no longer each burn the full budget (previously up to 2x900s = the whole 1800s job). - Upload retries are bounded by an overall 600s per-artifact budget: the deadline gates both the retry loop and each TUS chunk's request timeout, so a degraded endpoint cannot run out the 1800s process_video wall-clock. - _permanent_status classifies storage3 StorageApiError 4xx (e.g. a heatmap 413) as permanent, not just httpx.HTTPStatusError, so SDK-path 4xx aren't retried. Adds tests for SDK 4xx classification and the time-budget cutoff (7 pass).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses PR #86 review comments:
Adds tests for SDK 4xx classification and the time-budget cutoff (7 pass).