Add Nango function builder persona#63
Conversation
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds a built-in persona "nango-function-builder" (persona spec + AGENTS.md), registers it in routing/schema and personaCatalog, updates generate/export wiring, expands tests for persona resolution, and updates README docs to list the new built-in personas. ChangesNango Function Builder Persona Addition
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Updated in
Validation: |
|
@khaliqgant I'm not sure this should be a built in workforce persona. see https://github.com/AgentWorkforce/workforce/pull/43/changes for reference, but workforce has installable libraries we can leverage, this maybe is one? could be it's own package/repo as the nango set of personas? |
I don't understand why not actually. This is a persona for building nango-integrations, in my mind a perfect use case for a persona with a specific set of skills and silo'ed directory. I'm misunderstanding personas, it seems? |
|
@khaliqgant oh no it's a perfect persona I'm saying it shouldn't be in the workforce repo as a built in. There are three different types of personas
Built in's should be reserved for workforce related personas. A good example of a built in is the persona-builder. Related to personas directly, so everyone should have it when they install agentworkforce. This is probably a very small set of personas. Library personas are generalized that can be extended to multiple code bases. This is where I see the nango personas. Can be used in many repos, sort of like a "super skill". You can install these with Then there is the repo persona that get installed to An example of this is one I just PR'd into the relay repo: AgentWorkforce/relay#839 I obviously need to write more docs about this, but lmk if that makes sense. |
Ah yes, this makes perfect sense. Brilliant! (said with British accent) |
Summary
nango-function-builderpersona and sidecarAGENTS.mdnango-function-buildingthrough workload-router catalog, routing profile, schema, tests, and generated persona outputValidation
corepack pnpm --filter @agentworkforce/workload-router testNotes
corepack pnpm run checkcurrently fails in the existing CLI package before this persona change, due missing/mismatched@agentworkforce/harness-kitexports and missing@relayburn/sdktypes..claude/was left untouched.