Repository navigation
refactor(timeletter): 단순 back 위임 5개를 popBack 하나로 합친다 (#1301) - #2306
Closed
OnlyReadOneBook wants to merge 1 commit into
Closed
OnlyReadOneBook wants to merge 1 commit into
OnlyReadOneBook wants to merge 1 commit into
Conversation
Contributor
|
열린 PR 중 이 PR 과 같은 파일을 서로 다르게 고친 것이 있다. 어느 쪽이 먼저 머지되든 나중 쪽은 base 를 병합해야 통과한다 (#1750).
머지 자체는 GitHub 이 막는다 — 한쪽이 들어가면 다른 쪽은 CONFLICTING 이 되어 merge queue 에 못 들어간다. 이 코멘트는 리컨사일러가 매 실행 현재 상태로 고쳐 쓴다. 해소되면 |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
핵심 검토 파일:
TimeLetterNavActions.kt,TimeLetterNavGraph.kt(프로덕션)📌𝘐𝘴𝘴𝘶𝘦𝘴
📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯
TimeLetterNavActions의 단순 back 위임 5개(onWriteBack,onDraftBack,onRecipientBack,onDetailBack,onRecipientFilterBack)를popBack()하나로 합쳤습니다. 마음의 기록 NavActions 단순 back 위임 5개를 공통 명령으로 통합 #1311 과 같은 방식입니다.TimeLetterNavGraph의 화면 이벤트 이름은 그대로 두고 연결만popBack으로 바꿨습니다. 저장·등록 이벤트를 처리한 뒤 pop 하는 순서는 바뀌지 않았습니다.AppNavigationActions어댑터와 테스트 하네스NavBackStackHarness를 맞췄습니다.🧪 CI Test Plan
{ "androidTest": { "mode": "selected", "reason": "navigation/ 경로 변경. 타임레터 작성·수신인 선택·상세의 뒤로가기 경로를 지나는 계측 테스트를 고른다.", "tests": [ {"path": "app/src/androidTest/java/com/afternote/afternote_fe/TimeLetterMindRecordCompletionAndroidTest.kt", "selector": "com.afternote.afternote_fe.TimeLetterMindRecordCompletionAndroidTest#timeLetterRecipientSelector_roundTripPreservesTitleTextAndExactReceiverId", "device": "api34"}, {"path": "app/src/androidTest/java/com/afternote/afternote_fe/TimeLetterMindRecordCompletionAndroidTest.kt", "selector": "com.afternote.afternote_fe.TimeLetterMindRecordCompletionAndroidTest#timeLetterWrite_uiValidationAndRapidRegister_preserveInputAndCreateOnce", "device": "api34"}, {"path": "app/src/androidTest/java/com/afternote/afternote_fe/TimeLetterMindRecordCompletionAndroidTest.kt", "selector": "com.afternote.afternote_fe.TimeLetterMindRecordCompletionAndroidTest#timeLetterSenderDetail_routeIdLoadingFailureRetryAndSuccess_areConnected", "device": "api34"} ] } }📷𝘚𝘤𝘳𝘦𝘦𝘯𝘴𝘩𝘰𝘵
화면 변경 없음.
💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴
로컬 검증: 타임레터 presentation 컴파일, app 단위 테스트 컴파일, ktlintCheck, app 네비게이션 단위 테스트 통과.