Skip to content

[checkout] Code generation: update services and models - #390

Merged
mrcromero merged 3 commits into
mainfrom
sdk-automation/checkout
Aug 4, 2026
Merged

mrcromero merged 3 commits into
mainfrom
sdk-automation/checkout

Conversation

@AdyenAutomationBot

Copy link
Copy Markdown
Collaborator

This PR contains the automated changes for the checkout service.

The commit history of this PR reflects the adyen-openapi commits that have been applied.

@AdyenAutomationBot
AdyenAutomationBot force-pushed the sdk-automation/checkout branch from c406bc2 to 74b88b1 Compare July 13, 2026 09:45
@AdyenAutomationBot
AdyenAutomationBot requested a review from a team as a code owner July 13, 2026 09:45

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the default version of the Adyen Checkout service from 71 to 72 and updates the SDK generation log. The review feedback correctly points out that this version bump will cause test failures in spec/checkout_spec.rb because the test expectations still look for v71, and advises updating those tests to match the new default version.

attr_accessor :service, :version

DEFAULT_VERSION = 71
DEFAULT_VERSION = 72

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Updating DEFAULT_VERSION to 72 will cause test failures in spec/checkout_spec.rb because several test cases (such as those on lines 650 and 676) expect the URL version to be v71. Please update the corresponding test expectations in spec/checkout_spec.rb to use v72 to match this new default version.

@AdyenAutomationBot
AdyenAutomationBot force-pushed the sdk-automation/checkout branch 8 times, most recently from af9655d to a79a9cc Compare July 20, 2026 14:14
@AdyenAutomationBot
AdyenAutomationBot force-pushed the sdk-automation/checkout branch 5 times, most recently from 360ec1c to 38786dc Compare July 27, 2026 10:28
@AdyenAutomationBot
AdyenAutomationBot force-pushed the sdk-automation/checkout branch from 38786dc to beec683 Compare July 31, 2026 12:01
@mrcromero
mrcromero force-pushed the sdk-automation/checkout branch from a2021e4 to e1a55ce Compare August 4, 2026 12:10
@sonarqubecloud

sonarqubecloud Bot commented Aug 4, 2026

Copy link
Copy Markdown

end

# must be created manually because every field in the response is an array
it "makes a payment_methods call", focus: true do

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

focus: true is for filtering out tests during development (running a specific test). Removed this, seems to be a temporary marker from before that slipped in as the repo doesn't run tests with focus-filtering enabled, so it's inert.

@mrcromero

Copy link
Copy Markdown
Contributor

For reference, if anyone looks back at this PR, rundown of the test changes:

  • Fixed breaking tests (was quite straight-forward, just changing 71->72 in the endpoints)
  • Added tests for new payments endpoint (update_session)
  • While here:
    • Updated outdated mocks in tests (were still using old models)
    • Added tests for missing endpoints whose models were actually modified during the upgrade but were previously untested.

Regarding these extra changes:

  • Outdated mocks:
    • POST /payments/{paymentPspReference}/amountUpdates — request + response mocks
    • POST /orders — request + response mocks
    • POST /orders/cancel — response mock (invalid resultCode enum value)
    • POST /payments/details — request + response mocks
    • POST /paymentMethods/balance — request + response mocks
    • POST /paymentLinks — response mock + status code corrected to 201
    • POST /paymentMethods — response mock
    • DELETE /storedPaymentMethods/{storedPaymentMethodId} — status code corrected to 204
  • New (missing) tests -> note, I only added tests where models were changed via v72 but endpoints weren't already tested:
    • POST /payments — payments_api.payments
    • POST /payments/{paymentPspReference}/reversals — modifications_api.refund_or_cancel_payment
    • POST /cardDetails — payments_api.card_details
    • POST /donations — donations_api.donations
    • POST /donationCampaigns — donations_api.donation_campaigns
    • POST /paypal/updateOrder — utility_api.updates_order_for_paypal_express_checkout
    • POST /storedPaymentMethods — recurring_api.stored_payment_methods

@mrcromero
mrcromero added this pull request to the merge queue Aug 4, 2026
Merged via the queue into main with commit 5070d38 Aug 4, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants