[checkout] Code generation: update services and models - #390
Conversation
c406bc2 to
74b88b1
Compare
There was a problem hiding this comment.
Code Review
This pull request updates the default version of the Adyen Checkout service from 71 to 72 and updates the SDK generation log. The review feedback correctly points out that this version bump will cause test failures in spec/checkout_spec.rb because the test expectations still look for v71, and advises updating those tests to match the new default version.
| attr_accessor :service, :version | ||
|
|
||
| DEFAULT_VERSION = 71 | ||
| DEFAULT_VERSION = 72 |
There was a problem hiding this comment.
af9655d to
a79a9cc
Compare
360ec1c to
38786dc
Compare
38786dc to
beec683
Compare
beec683 to
af46b16
Compare
a2021e4 to
e1a55ce
Compare
|
| end | ||
|
|
||
| # must be created manually because every field in the response is an array | ||
| it "makes a payment_methods call", focus: true do |
There was a problem hiding this comment.
focus: true is for filtering out tests during development (running a specific test). Removed this, seems to be a temporary marker from before that slipped in as the repo doesn't run tests with focus-filtering enabled, so it's inert.
|
For reference, if anyone looks back at this PR, rundown of the test changes:
Regarding these extra changes:
|



This PR contains the automated changes for the
checkoutservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.