Skip to content

[balanceplatform] Code generation: update services and models - #385

Merged
mrcromero merged 2 commits into
mainfrom
sdk-automation/balanceplatform
Aug 3, 2026
Merged

mrcromero merged 2 commits into
mainfrom
sdk-automation/balanceplatform

Conversation

@AdyenAutomationBot

Copy link
Copy Markdown
Collaborator

This PR contains the automated changes for the balanceplatform service.

The commit history of this PR reflects the adyen-openapi commits that have been applied.

@AdyenAutomationBot
AdyenAutomationBot requested a review from a team as a code owner May 19, 2026 12:23

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the BalancePlatform service by moving sweep-related methods from BalanceAccountsApi to a new CustomPayoutSchedulesSweepsApi class and introducing a ManagedPayoutSchedulesApi class. A critical issue was identified where existing tests in spec/balance_platform_spec.rb were not updated to reflect these changes, which will lead to test failures when calling the moved methods.

I am having trouble creating individual review comments. Click here to see my feedback.

lib/adyen/services/balancePlatform/balance_accounts_api.rb (23-45)

critical

The sweep-related methods have been moved from BalanceAccountsApi to the new CustomPayoutSchedulesSweepsApi class, but the tests in spec/balance_platform_spec.rb have not been updated. This will cause existing tests to fail. For example, the test 'makes a balance_account/sweeps DELETE call' still calls balance_accounts_api.delete_sweep. Please update the tests to call these methods from the new custom_payout_schedules_sweeps_api.

@AdyenAutomationBot
AdyenAutomationBot force-pushed the sdk-automation/balanceplatform branch from 5d23244 to a79c5d4 Compare May 19, 2026 14:55
@AdyenAutomationBot
AdyenAutomationBot force-pushed the sdk-automation/balanceplatform branch 4 times, most recently from 7c8ba88 to c69db27 Compare June 2, 2026 15:29
@AdyenAutomationBot
AdyenAutomationBot force-pushed the sdk-automation/balanceplatform branch from c69db27 to 145c073 Compare June 4, 2026 13:32
@AdyenAutomationBot
AdyenAutomationBot force-pushed the sdk-automation/balanceplatform branch 3 times, most recently from bf03365 to c65e7a2 Compare June 17, 2026 09:05
@sonarqubecloud

Copy link
Copy Markdown

@AdyenAutomationBot
AdyenAutomationBot force-pushed the sdk-automation/balanceplatform branch from c65e7a2 to 5f8be47 Compare June 19, 2026 10:10
@sonarqubecloud

Copy link
Copy Markdown

@AdyenAutomationBot
AdyenAutomationBot force-pushed the sdk-automation/balanceplatform branch 6 times, most recently from 91650f9 to 8fb2f7e Compare June 24, 2026 08:32
@AdyenAutomationBot
AdyenAutomationBot force-pushed the sdk-automation/balanceplatform branch 3 times, most recently from 85d498f to 98161f4 Compare July 7, 2026 09:20
@AdyenAutomationBot
AdyenAutomationBot force-pushed the sdk-automation/balanceplatform branch 7 times, most recently from 03e4146 to f0be8a1 Compare July 15, 2026 14:59
@AdyenAutomationBot
AdyenAutomationBot force-pushed the sdk-automation/balanceplatform branch 5 times, most recently from 1220ab8 to e48aa1e Compare July 22, 2026 11:24
@AdyenAutomationBot
AdyenAutomationBot force-pushed the sdk-automation/balanceplatform branch 3 times, most recently from ef1e11b to 9be4563 Compare July 27, 2026 10:29
@AdyenAutomationBot
AdyenAutomationBot force-pushed the sdk-automation/balanceplatform branch from 9be4563 to 53a7578 Compare July 31, 2026 12:01
Comment thread spec/balance_platform_spec.rb

@andrej-gajduk-adyen andrej-gajduk-adyen left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrcromero
mrcromero force-pushed the sdk-automation/balanceplatform branch from ba57bd8 to 825fbbe Compare August 3, 2026 08:54
@sonarqubecloud

sonarqubecloud Bot commented Aug 3, 2026

Copy link
Copy Markdown

@mrcromero
mrcromero added this pull request to the merge queue Aug 3, 2026
Merged via the queue into main with commit b45e250 Aug 3, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants