Skip to content

feat: add onAuthorize callback to ApplePay (COSDK-473)#1092

Merged
descorp merged 5 commits into
developfrom
feat/applepay-authorize
May 13, 2026
Merged

feat: add onAuthorize callback to ApplePay (COSDK-473)#1092
descorp merged 5 commits into
developfrom
feat/applepay-authorize

Conversation

@descorp
Copy link
Copy Markdown
Contributor

@descorp descorp commented May 11, 2026

Adds the onAuthorize callback to ApplePayConfiguration, letting merchants validate payment data before submission. Auto-resolves with success if no callback is configured.

Ticket: COSDK-473

Chain: 1/3 — PR2 (shipping) targets this branch.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements the Apple Pay authorization callback, enabling custom validation before payment submission. It adds the onAuthorize callback to the configuration, handles event bridging between native and JavaScript, and includes error mapping for the Apple Pay sheet. A high-severity issue was found in the native implementation where PKContactField was incorrectly initialized using a non-existent method.

Comment thread ios/Components/ApplePay/ApplePayModuleUtilities.swift
erenbesel
erenbesel previously approved these changes May 11, 2026
Robert-SD
Robert-SD previously approved these changes May 11, 2026
Comment thread src/core/configurations/ApplePayConfiguration.ts
Comment thread src/core/constants.ts
…xtract ApplePayAuthorizationResult to internal types (COSDK-473)
@descorp descorp dismissed stale reviews from ribeiroguilherme, Robert-SD, and erenbesel via 2d6cd74 May 12, 2026 13:22
Copy link
Copy Markdown

@johnayeni johnayeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
77.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@descorp descorp merged commit e131cd2 into develop May 13, 2026
15 of 17 checks passed
@descorp descorp deleted the feat/applepay-authorize branch May 13, 2026 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants