[foreignexchange] Code generation: update services and models - #509
AdyenAutomationBot wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the auto-generated AdyenForeignExchangeApi service and its associated RatesApi with a calculate endpoint. However, the new service name "foreignExchange" is not registered in the version_lookup dictionary in Adyen/client.py, which will result in a KeyError if alternative API versions are configured. Additionally, the new service needs to be exposed and instantiated in Adyen/__init__.py.
|
|
||
| def __init__(self, client=None): | ||
| super().__init__(client=client) | ||
| self.service = "foreignExchange" |
There was a problem hiding this comment.
The service name "foreignExchange" is not registered in AdyenClient._set_url_version's version_lookup dictionary (located in Adyen/client.py). If a user configures any other API version on the client (which makes any(versions) evaluate to True), calling calculate will result in a KeyError: 'foreignExchange' when _set_url_version is invoked. Please ensure that Adyen/client.py is updated to include "foreignExchange" in version_lookup and that Adyen/init.py is updated to expose and instantiate the new AdyenForeignExchangeApi service.
d948ea8 to
63b334e
Compare
|
This branch has not been deployed
1 participant
This PR contains the automated changes for the
foreignexchangeservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.