Skip to content

Adding support for child node in react-iframe #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MananTheMoon wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adding support for child node in react-iframe #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/iframe.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const Iframe: ComponentType<IIframe>
frameBorder, ariaHidden, sandbox, allow,
className, title, ariaLabel, ariaLabelledby,
name, target, loading, importance, referrerpolicy,
allowpaymentrequest, src
allowpaymentrequest, src, children
}: IIframe) => {

const defaultProps = objectAssign({
Expand Down Expand Up @@ -70,7 +70,9 @@ const Iframe: ComponentType<IIframe>
props.style.border = frameBorder
}
}
return <iframe {...props}/>
return <iframe {...props}>
{children}
</iframe>

}

Expand Down
3 changes: 3 additions & 0 deletions src/types.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import React from "react"

export interface IIframe {
url: string,
src?: string,
Expand Down Expand Up @@ -27,4 +29,5 @@ export interface IIframe {
allow?: string,
className?: string,
title?: string
children?: React.ReactNode,
}