Skip to content

⚠️ VIOLATION — DO NOT USE: causal_diff wrote non-palette values into CE64 S/P/O - #366

Closed
AdaWorldAPI wants to merge 2 commits into
masterfrom
ccr-9f3b8075-74u47l-ce64-causal-diff
Closed

AdaWorldAPI wants to merge 2 commits into
masterfrom
ccr-9f3b8075-74u47l-ce64-causal-diff

Conversation

@AdaWorldAPI

@AdaWorldAPI AdaWorldAPI commented Oct 17, 2026 •

Copy link
Copy Markdown
Owner

Caution

⚠️ LAYOUT VIOLATION. DO NOT MERGE, DO NOT CHERRY-PICK, DO NOT USE AS PRECEDENT.

This change wrote a block number, a projection enum and a verb code into CausalEdge64 bits 0..23. Those bits hold S/P/O palette256 codes in the canonical layout (lance-graph causal_edge::layout), so this gave them a second meaning.

causal_diff::CausalEdge64 is a weight-diff record, not a causal edge. It stays open, and its word is not touched until real S/P/O palette codes exist for it.

The word now carries S = block, P = projection code and O = verb code in
bits 0..23, NARS frequency at 24..31 and confidence at 32..39, with the
contract bits 40..63 left at their default. The row index and L1
distance have no field in the canonical word; they stay in WeightEdge.
row_idx() and l1_distance() keep their signatures, are deprecated and
return 0.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
@coderabbitai

coderabbitai Bot commented Oct 17, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Owner Author

Closing: this change violates the canonical CE64 layout. Bits 0..23 are S/P/O palette256 codes. This PR writes a block number, a projection enum and a verb code into them, which gives those slots a second meaning. That is the drift the layout work exists to remove. It also makes row_idx() / l1_distance() return 0, which hands callers invented data. Not to be merged.


Generated by Claude Code

@AdaWorldAPI AdaWorldAPI changed the title fix(causal_diff): pack CausalEdge64 in the canonical CE64 layout ⚠️ VIOLATION — DO NOT USE: causal_diff wrote non-palette values into CE64 S/P/O Oct 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants