Repository navigation
simd: eq_u32_via_lane_to_mask (lane-valued twin of eq_u32_via_to_mask) - #364
Closed
AdaWorldAPI wants to merge 2 commits into
Closed
AdaWorldAPI wants to merge 2 commits into
AdaWorldAPI wants to merge 2 commits into
Conversation
…mask Row i matches when table[index[i]] == local[i]. Closes a cyclic join in one pass where a constant compare needs one disjunct per value. Scalar; sibling's vectorisation note corrected (an unbounded f32 gather exists, a bounds-masked u32 gather-and-compare does not). Parity code 0xD41. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ndarray::simd::eq_u32_via_lane_to_mask(index, table, local, out_words)packsindex[i] < table.len() && table[index[i]] == local[i]into a bitmask. It is the lane-valued twin ofeq_u32_via_to_mask: each row compares against its own lane value instead of one constant.Why
lance-graph D-ASM-11A (
.claude/plans/wcoj-closing-atoms-v1.md§2, spec ratified by a 5+3 council). The closing atom of a cyclic join compares a row's own lane with a foreign lane read through an address lane. With today's constant-valued compare it can only be written as one disjunct per value, which grows by about 4 ops per value (66 ops at |D| = 16, 1,026 at 256). Consumer site (W1a criterion 7):lance-graph-mask-riscexec.rsrun_pred, the newPred::EqU32ViaLanearm.Contract
index[i]never matches, as with the sibling kernel.index.len()and surplus words are cleared.local.len() != index.len()or ifout_wordsis too short.unsafe, unboundedf32gather exists, but no bounds-maskedu32gather-and-compare wrapper, which the zero-fallback contract needs. Whether such a wrapper pays is unmeasured (lance-graph TD-NO-BOUNDED-U32-GATHER-1).Verified
local[0]turned 2 of the tests red; the change was reverted.simd-masking-parityOK on the v4 arm (avx512f=true), new group 0xD41. With one scalar body this only shows portability, not agreement between backends.cargo clippy --lib -- -D warningsclean; touched files rustfmt-clean. The parity crate's existing import block is not rustfmt-clean, so the new function is imported on its own line to keep the diff small.🤖 Generated with Claude Code
https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
Generated by Claude Code