Spruce - Michelle Morales#15
Open
DynamicDev3000 wants to merge 2 commits into
Open
Conversation
kyra-patton
reviewed
May 29, 2022
kyra-patton
left a comment
kyra-patton
left a comment
There was a problem hiding this comment.
🤠💫 Very solid implementation, Michelle! Make sure you fork against the C16 version instead of AdaGold next time! Let me know what questions you have.
🟢
| self.size = 0 | ||
|
|
||
|
|
||
| def enqueue(self, element): |
| self.rear = (self.rear + 1) % self.buffer_size | ||
| self.size += 1 | ||
|
|
||
| def dequeue(self): |
| self.rear = -1 | ||
| return value | ||
|
|
||
| def front(self): |
| self.buffer_size = INITIAL_QUEUE_SIZE | ||
| self.front = -1 | ||
| self.rear = -1 | ||
| self.rear = 0 |
There was a problem hiding this comment.
There's not really anything wrong with initializing this to 0, but since you reset it to '-1' in dequeue below when the queue becomes empty, it's best to stay consistent across the board.
Suggested change
| self.rear = 0 | |
| self.rear = -1 |
Comment on lines
+65
to
+67
| if self.front == -1: | ||
| return 0 | ||
| return self.size |
There was a problem hiding this comment.
Since size should already be 0 if the queue is empty, you can probably delete lines 65 - 66.
Suggested change
| if self.front == -1: | |
| return 0 | |
| return self.size | |
| return self.size |
| for x in range(size): | ||
| result.append(self.store[index]) | ||
| index = (index + 1) % self.buffer_size | ||
| size -= 1 |
There was a problem hiding this comment.
We generally try not to change the value we are iterating through, and it's not necessary to modify size here.
Suggested change
| size -= 1 |
| Returns None | ||
| """ | ||
| pass | ||
| self.store.add_first(element) |
| returns None | ||
| """ | ||
| pass | ||
| return self.store.remove_first() |
| And False otherwise | ||
| """ | ||
| pass | ||
| return self.store.empty() |
| ending with the bottom of the Stack. | ||
| """ | ||
| pass | ||
| return str(self.store) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacks and Queues
Thanks for doing some brain yoga. You are now submitting this assignment!
Comprehension Questions
OPTIONAL JobSimulation