Skip to content

Dionisia Edges Rideshare#46

Open
larachan15 wants to merge 3 commits into
Ada-C10:masterfrom
larachan15:master
Open

Dionisia Edges Rideshare#46
larachan15 wants to merge 3 commits into
Ada-C10:masterfrom
larachan15:master

Conversation

@larachan15

Copy link
Copy Markdown

ride share

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
What did your data structure look like at first? Did this structure evolve over time? Why? At first I arranged the data by date. Then I arranged it by driver because the questions were about each driver.
What was your strategy for going through the data structure and gathering information? I used nested each loops to access the inner most layers. I had an array with a hash that had an array with hashes.
What was an example of something that was necessary to store in a variable? What was the scope of that variable? Why? I had the sum of the ratings stored in a definition so that I could output it later when I called that method.
What kinds of iteration did you use? Did you use .map? I used times and each. I don't know if I fully understand .map yet to use it.
Were some calculations easier than others? Why? Making the layers of loops were much more difficult for me than the calculations because I couldn't understand what each layer was doing. I used a lot of puts statements nestled in between to see how the code was iterating over the data.

@droberts-sea

Copy link
Copy Markdown

Good work overall! Your datastructure makes a lot of sense for solving this problem. I also appreciate the way you used methods to break up your code - it makes the flow of the program much easier to follow. One nitpick I will share is that your indentation is off in some places - make sure you're using the auto-indenter. In general though I am quite happy with this submission - keep up the hard work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants