Skip to content

hayden-rideshare.rb#38

Open
halcyon-and-on wants to merge 2 commits into
Ada-C10:masterfrom
halcyon-and-on:master
Open

hayden-rideshare.rb#38
halcyon-and-on wants to merge 2 commits into
Ada-C10:masterfrom
halcyon-and-on:master

Conversation

@halcyon-and-on

@halcyon-and-on halcyon-and-on commented Aug 13, 2018

Copy link
Copy Markdown

ride share

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
What did your data structure look like at first? Did this structure evolve over time? Why? It was very similar at first, but the date was stored in each individual ride instead the date being a layer of its own
What was your strategy for going through the data structure and gathering information? I wrote pretty much all of my code using each loops
What was an example of something that was necessary to store in a variable? What was the scope of each of that variables? Why? Again and again I had to store each driver's individual hash in an iteration variable that had a scope of only the particular iteration of the each loop it was created for
What kinds of iteration did you use? Did you use .map? I did not use '.map'. I probably should have gone back and rewritten it that way but I stuck with the each loops.
Were some calculations easier than others? Why? Yes. The optional question at the end was vexing because I couldn't find an easy way to solve it other than to re-organize my data structure. It focused on finding averages for each date for each driver and to do that I needed the date as a layer itself. (I just noticed this was NOT what the optional question was, but let's pretend I wasn't that sleep deprived last week!!)

@droberts-sea

Copy link
Copy Markdown

Great work overall! This code is easy to read and does a good job of addressing the questions. I especially appreciate the way you broke your code up into separate methods - this makes the flow of the program much easier to follow. Keep up the hard work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants