Sammi-Jo's ride share! (nodes)#34
Open
sjlee3157 wants to merge 6 commits into
Open
Conversation
Update ride-share.rb
replaced complex conditional with lookup hash
|
Wow, nice work with the table and sorting of data, really nice work! You hit all the learning goals for the project! Sorry for missing the top earners and top-rated messages earlier. |
CheezItMan
reviewed
Aug 17, 2018
|
|
||
| master = { | ||
| drivers: [ | ||
| { driver_id: "DR0002" , |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ride share
Congratulations! You're submitting your assignment.
Comprehension Questions
top_driveris a hash that was created outside of any other method because I wanted methods to create/return objects to fill it with. top_driver is not natively accessible to methods, so it has to be passed in as an argument. The objects that other methods fill it with had to be returned, because they have no scope outside of the method..map?.reducea lot! I had to use.eachto do a multi-part task (line 122), but.reducedid a lot of work for me elsewhere. I used.maponce to identify the top scorer(s) by driver id.