Skip to content

fix(sidebar): protect collapsible lists from plugin hidden styles#2097

Merged
bajrangCoder merged 2 commits into
Acode-Foundation:mainfrom
bajrangCoder:fix/sidebar-collapsible-plugin-css
May 10, 2026
Merged

fix(sidebar): protect collapsible lists from plugin hidden styles#2097
bajrangCoder merged 2 commits into
Acode-Foundation:mainfrom
bajrangCoder:fix/sidebar-collapsible-plugin-css

Conversation

@bajrangCoder
Copy link
Copy Markdown
Member

No description provided.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 10, 2026

Greptile Summary

This PR adds display: block !important to the .list.collapsible.hidden rule in list.scss, preventing plugin stylesheets that target .hidden from fully hiding the collapsible container in the sidebar.

  • The new !important declaration wins over a plugin's display: none !important on .hidden because the three-class selector (.list.collapsible.hidden, specificity 0,3,0) outweighs a plain .hidden rule (specificity 0,1,0) — CSS specificity still governs competing !important declarations within the same origin.
  • The icon-content overrides (.folder::before, .indicator::before) already used !important; the container's display declaration is now consistent with that pattern.

Confidence Score: 5/5

Single-line CSS addition that restores container visibility against plugin overrides; no JavaScript, no logic, no regressions expected.

The change is a one-line addition to a well-scoped CSS block. The three-class selector gives it enough specificity to win over typical plugin .hidden overrides even when both sides use !important. No other files are touched and the fix is self-contained.

No files require special attention.

Important Files Changed

Filename Overview
src/styles/list.scss Adds display: block !important to .list.collapsible.hidden so that plugin stylesheets targeting .hidden cannot fully hide the collapsible container; the collapsed child ul still uses display: none without !important.

Reviews (2): Last reviewed commit: "fix" | Re-trigger Greptile

Comment thread src/styles/list.scss Outdated
@bajrangCoder

This comment was marked as outdated.

@bajrangCoder bajrangCoder merged commit 4c83d3f into Acode-Foundation:main May 10, 2026
7 checks passed
@bajrangCoder bajrangCoder deleted the fix/sidebar-collapsible-plugin-css branch May 10, 2026 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants