Reject DWA RLE streams shorter than required channel data#2544
Closed
cary-ilm wants to merge 1 commit into
Closed
Conversation
A malformed DWAA/DWAB chunk can declare RLE_RAW_SIZE smaller than the byte count needed by RLE-classified channels. The decoder only rejected sizes larger than the planar buffer, so the RLE expander filled fewer raw bytes than the channel reconstruction consumed and stale heap contents were copied into caller-visible pixel output. After classifying channels, sum each RLE channel's planarUncSize and reject the chunk when RLE_RAW_SIZE is smaller than that total or when RLE data is required but no compressed RLE stream is present. Also reject non-zero RLE stream sizes when no channels require RLE data. Addresses https://github.com/AcademySoftwareFoundation/openexr/security/advisories/GHSA-wwx8-2v36-rhr8 Signed-off-by: Cary Phillips <cary@ilm.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Member
Author
|
got a better idea |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A malformed DWAA/DWAB chunk can declare RLE_RAW_SIZE smaller than the byte count needed by RLE-classified channels. The decoder only rejected sizes larger than the planar buffer, so the RLE expander filled fewer raw bytes than the channel reconstruction consumed and stale heap contents were copied into caller-visible pixel output.
After classifying channels, sum each RLE channel's planarUncSize and reject the chunk when RLE_RAW_SIZE is smaller than that total or when RLE data is required but no compressed RLE stream is present. Also reject non-zero RLE stream sizes when no channels require RLE data.
Addresses https://github.com/AcademySoftwareFoundation/openexr/security/advisories/GHSA-wwx8-2v36-rhr8