Fix exrmultiview heap OOB when union dataWindow misaligns with subsampling#2530
Merged
cary-ilm merged 3 commits intoJul 13, 2026
Merged
Conversation
cary-ilm
changed the title
Collaborator
|
I wonder if a better "fix" would be to prevent exrmultiview supporting sampling!=1 regardless of the data window. |
…pling Validate the combined data window against each input channel's x/y subsampling before allocating pixel buffers or calling readPixels, matching ImfHeader checks. Reject misaligned unions with ArgExc instead of reading past undersized buffers. Addresses https://github.com/AcademySoftwareFoundation/openexr/security/advisories/GHSA-gjf7-wjjw-xq56 Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Cary Phillips <cary@ilm.com>
Subsampling is rare, and exrmultiview not commonly used, so this solution seems cleaner: just don't handle subsampling at all. Signed-off-by: Cary Phillips <cary@ilm.com>
cary-ilm
force-pushed
the
GHSA-gjf7-wjjw-xq56.2
branch
from
July 9, 2026 17:00
e28268c to
bad9905
Compare
Member
Author
|
@peterhillman, I took your suggestion and added a condition to reject any input with non-default sampling. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate the combined data window against each input channel's x/y subsampling before allocating pixel buffers or calling readPixels, matching ImfHeader checks. Reject misaligned unions with ArgExc instead of reading past undersized buffers.
Addresses https://github.com/AcademySoftwareFoundation/openexr/security/advisories/GHSA-gjf7-wjjw-xq56