fix(summary): centralized DOMAIN_DISPLAY/TITLE maps; sweep 4 prose sites (v0.4.3)#43
Merged
Merged
Conversation
…tes (v0.4.3)
Reading the v0.4.2 output, found the domain enum value leaking into
prose at 4 distinct sites:
1. **Ml** (uni technical-depth heading) — capitalizeFirst('ml') →
"Ml" instead of "ML" / "Machine Learning"
2. "2 ml projects in Python" (uni technical-depth sentence body) —
raw enum 'ml' interpolated
3. "An active ml project built primarily in Python" (uni per-project
intro) — same raw 'ml' leak
4. "A ml project in Python." (case-studies overview fallback when
description is null) — same root cause
Fix: two new exported maps in @portfoliocraft/core:
DOMAIN_DISPLAY — lowercase mid-sentence: 'machine-learning', 'DevOps'
DOMAIN_TITLE — Title Case heading: 'Machine Learning', 'DevOps'
Used at all 4 prose sites + tightened TechnicalDepthEntry.domain
schema from z.string() to the existing Domain enum so renderers can
safely index without runtime fallback. Builder always emitted enum
values; schema was looser than the data.
Removed the now-dead capitalizeFirst helper in summary-uni.ts.
Pattern recorded for future renderer work: when a prose-rendering bug
appears in one site, audit the WHOLE module for sibling sites that
share the shape. v0.4.0 → v0.4.3 has been a chain of catch-up because
each patch was localized. v0.4.3's fix is centralised so the next
"an X" or "title-case domain" need never reopens.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
AuditGenerated 2026-05-01. 154 findings across 85 repos (53 flagged).
Verified signal
Findings
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reading the v0.4.2 dogfood output found 4 sites where the `Domain` enum value was leaking directly into prose:
All same root cause: raw enum values (`ml`, `devops`) were being interpolated into rendered text. Fixed at the source with two new exported maps in `@portfoliocraft/core`:
Used at all 4 prose sites + tightened `TechnicalDepthEntry.domain` schema from `z.string()` to the existing `Domain` enum so renderers can safely index without runtime fallback.
Pattern recorded
This is the third v0.4.x patch where reading the rendered output found bugs the unit tests, lint, and CodeQL gates all missed. They were structurally correct; just embarrassing to read.
Process gate going forward: when a prose-rendering bug appears in one site, audit the whole renderer module for sibling sites. v0.4.0 → v0.4.3 has been a chain of catch-up because each patch was localized. v0.4.3 closes the audit by centralizing.
Test plan