Skip to content

Move SCC Index page to React#166

Merged
m-bucher merged 1 commit into
masterfrom
move-scc-index-page-to-react
Oct 31, 2025
Merged

Move SCC Index page to React#166
m-bucher merged 1 commit into
masterfrom
move-scc-index-page-to-react

Conversation

@EnigmaXV

Copy link
Copy Markdown
Contributor
  • Implement React-based SCC Index page (components + actions)
  • Update index view and webpack entry

@EnigmaXV EnigmaXV force-pushed the move-scc-index-page-to-react branch 2 times, most recently from ca94742 to 97986b8 Compare October 22, 2025 14:32
@m-bucher m-bucher self-requested a review October 23, 2025 08:15

@m-bucher m-bucher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks quite good already.

  1. Is it intentional to drop Pagination and the Searchbar?
  2. IMHO the spacing between the rows seems a little to big
  3. Please do not forget to add Tests 😉

Comment thread webpack/components/SCCAccountIndex/index.js Outdated
Comment thread webpack/components/SCCAccountIndex/index.js Outdated
Comment thread webpack/components/SCCAccountIndex/SCCAccountIndexActions.js Outdated
@sbernhard

Copy link
Copy Markdown
Member
  1. Is it intentional to drop Pagination and the Searchbar?
    Pagination is, normally not necessary. Most users have 1 account. maybe 2 :)

@EnigmaXV EnigmaXV force-pushed the move-scc-index-page-to-react branch 2 times, most recently from 43789a3 to 61b92dd Compare October 29, 2025 12:24
@EnigmaXV EnigmaXV requested a review from m-bucher October 29, 2025 15:11
@EnigmaXV EnigmaXV force-pushed the move-scc-index-page-to-react branch 2 times, most recently from 9ac9898 to 0d53650 Compare October 30, 2025 10:37
- Implemented React-based SCC Index page (components + actions)
- Updated index view and webpack entry
- Added unit tests
- Removed search bar and pagination
@EnigmaXV EnigmaXV force-pushed the move-scc-index-page-to-react branch from 0d53650 to 87173c3 Compare October 30, 2025 10:45

@m-bucher m-bucher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks.

@m-bucher m-bucher merged commit 2180b73 into master Oct 31, 2025
15 checks passed
@m-bucher m-bucher deleted the move-scc-index-page-to-react branch October 31, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants