Skip to content

add GSLC faraday rotation notebook, update myst.yml and pixi configs#26

Draft
Alex-Lewandowski wants to merge 4 commits into
mainfrom
feature/faraday_rotation_estimation
Draft

add GSLC faraday rotation notebook, update myst.yml and pixi configs#26
Alex-Lewandowski wants to merge 4 commits into
mainfrom
feature/faraday_rotation_estimation

Conversation

@Alex-Lewandowski

Copy link
Copy Markdown
Contributor
  • Add notebooks/GSLC_Faraday_Rotation_Estimation.ipynb
  • Update myst.yml to add new notebook to TOC
  • Add hvplot and geoviews to isce3 Pixi env to support plotting in new notebook

@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions

github-actions Bot commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: da04cbc
✅ Deployment Preview URL: https://ASFOpenSARlab.github.io/NISAR_Cookbook/_preview/26

@jwhite124

Copy link
Copy Markdown
Contributor

It's not letting me review on Git, but I checked out the branch locally.

  • In section 3b, in the commented code, you might change "project" to "projection"

@jwhite124

Copy link
Copy Markdown
Contributor
  • In the markdown text of section 4, you might add "this section" before "uses"

@jwhite124

Copy link
Copy Markdown
Contributor
  • there's also some (blue) commented out code in the first code cell under section 4. You may not need the references in the markdown and the code, but I also am not fully up to date with how that should be

@jwhite124

Copy link
Copy Markdown
Contributor

If you wanted, you could also add this paper from section 4 - S. H. Bickel and R. H. T. Bates, “Effects of magneto-ionic propagation on the polarization scattering matrix,” Proc. IEEE, vol. 53, no. 8, pp. 1089–1091, Aug. 1965 to the references

@jwhite124

Copy link
Copy Markdown
Contributor

This might be intentional, but Section 6 (markdown) also has an indention that the rest of the headers don't have

@jwhite124

Copy link
Copy Markdown
Contributor

Section 2 popup/ markdown also says "search for GCOV data"

@jwhite124

Copy link
Copy Markdown
Contributor

The overview popups for 4 show sections 4 & 5 and the popup for section 5 shows sections 5 & 6

@jwhite124

Copy link
Copy Markdown
Contributor

Also, not a suggestion, but the visualization is very cool! I like that you can download the image so easily.

@jwhite124

Copy link
Copy Markdown
Contributor

The NISAR Data user guide link also takes you to the Direct AWS S3 Access page

@Alex-Lewandowski Alex-Lewandowski marked this pull request as draft June 15, 2026 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants