FIX: Fixes mismatch shape issue.#1755
Merged
Merged
Conversation
mgrover1
requested changes
May 27, 2025
mgrover1
left a comment
mgrover1
left a comment
Collaborator
There was a problem hiding this comment.
Any chance you could add a test here?
Collaborator
Author
|
@mgrover1 Good point! I could do that |
Collaborator
|
Following up here - any chance a test could be added? |
Collaborator
Author
|
@mgrover1 Yep! Sorry I kinda forgot about this one |
mgrover1
approved these changes
Jun 16, 2025
mgrover1
left a comment
mgrover1
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for making these changes @zssherman !!
Collaborator
Author
|
@mgrover1 test has been added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue of mismatch shape x and y for cfad. If no mask is provided, will check for existing mask in field data and apply it to the altitude data, similar to if a mask is provided by the user.