Improve the error output#148
Open
ric394 wants to merge 2 commits into
Open
Conversation
ric394
added
the
ready for software review
There was a problem hiding this comment.
Pull request overview
This pull request addresses issue #147 by improving HTTP error outputs produced by APSIM.POStats.Shared.WebUtilities, aiming to include the offending URL in error messages and reduce noisy HTML output.
Changes:
- Include the request method and URL in thrown/printed error messages when requests fail.
- Attempt to reduce HTML noise by extracting the
<body>portion of HTML responses before logging/returning.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
63
to
+67
| output += $"Request:\n{response}\n"; | ||
| output += $"Response:\n{body}\n"; | ||
|
|
||
| Console.WriteLine($"Error sending POST Request\n{output}"); | ||
| throw new Exception($"Error sending POST Request\n{output}"); | ||
| Console.WriteLine($"Error sending {type} for URL {requestUrl} Request\n{output}"); | ||
| throw new Exception($"Error sending {type} for URL {requestUrl} Request\n{output}"); |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #147
This adds the offending URL to error outputs and removes the full html plain text output in favour of the body text only.