#370 Fix Improve Debate Details modal layout, scrolling, and content visibility#374
#370 Fix Improve Debate Details modal layout, scrolling, and content visibility#374hritikkumar07 wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughIgnored production config added; sample prod config placeholders standardized; a trailing newline added to a backend Dockerfile; a frontend support route was disabled; and the Profile page "Debate Details" modal layout was adjusted to use a scrollable column flex layout. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@backend/Dockerfile.dev`:
- Around line 23-27: Remove the invalid global GOFLAGS=-insecure and stop using
blanket "*" patterns for GONOSUMCHECK, GONOSUMDB, and GONOPROXY; instead set
GOPRIVATE to the specific private module path(s) you need (which will scope
GONOSUMDB/GONOPROXY behavior) and, only if required for specific hosts, set
GOINSECURE and GOPROXY for those specific domains (not "*"); update the ENV
entries so they use GOPRIVATE=<your-private-modules> and optionally
GOINSECURE=<comma-separated-hosts> and GOPROXY=<proxy-for-specific-hosts> while
removing GOFLAGS and the global "*" entries.
In `@frontend/src/App.tsx`:
- Line 20: The commented import and removed route for the SupportOpenSource
component (formerly imported as SupportOpenSource) caused header links to
/support-debateai to fall through to the wildcard redirect; restore the import
for SupportOpenSource and re-add the Route that mounts it at path
"/support-debateai" in the router configuration so header links resolve
correctly (ensure the route is registered before the wildcard Redirect/Route
that handles unknown paths).
In `@frontend/src/Pages/Profile.tsx`:
- Line 1437: The inner div with classes "max-h-48 overflow-y-auto border
rounded-lg p-3 space-y-3" creates a nested scroll region; remove the
constraining classes (remove "max-h-48" and "overflow-y-auto") so the content
flows and the parent scroll container handles scrolling, e.g., replace them with
no max-height (or "max-h-full"/"max-h-none") and use "overflow-visible" if
needed; update the JSX element that renders the "Full Conversation" message box
accordingly to avoid the inner scrollbar while preserving border/padding
classes.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 827a2cf6-094c-487d-a0f8-6ef482e9152b
📒 Files selected for processing (6)
.gitignorebackend/Dockerfile.devbackend/config/config.prod.sample.ymlfrontend/.gitignorefrontend/src/App.tsxfrontend/src/Pages/Profile.tsx
| ENV GONOSUMCHECK=* | ||
| ENV GOFLAGS=-insecure | ||
| ENV GONOSUMDB=* | ||
| ENV GONOPROXY=* | ||
| ENV GOPROXY=direct No newline at end of file |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
In Go 1.24, is -insecurevalid inGOFLAGS? What are the recommended env vars for private/insecure module fetching (GOPRIVATE, GONOSUMDB, GONOPROXY, GOINSECURE)?
💡 Result:
No, the -insecure flag is not valid in GOFLAGS in Go 1.24. GOFLAGS supports command flags known by the current go subcommand (like -ldflags, -gcflags), but -insecure is a legacy flag primarily for go get that has been deprecated since Go 1.14 in favor of GOINSECURE. It is not listed among standard build flags shared across commands, and source code handling shows GOFLAGS applies flags recognized by the specific command. No Go 1.24 documentation or release notes mention -insecure support in GOFLAGS. The recommended environment variables for private/insecure module fetching are: - GOPRIVATE: Comma-separated glob patterns for private module path prefixes. Acts as default for GONOPROXY, GONOSUMDB, and affects GOVCS. Bypasses proxy and checksum DB, fetches directly via VCS. - GONOPROXY: Glob patterns for modules not to request from any proxy (use direct VCS). Overrides GOPRIVATE for proxy decision. - GONOSUMDB: Glob patterns for modules not to check against public checksum DB (sum.golang.org). - GOINSECURE: Glob patterns for module path prefixes to fetch insecurely (e.g., plain HTTP, skipping TLS verification). Only for direct fetches; does not disable sum DB validation (use with GOPRIVATE/GONOSUMDB). Set persistently with go env -w VAR=value. For example: go env -w GOPRIVATE=.corp.example.com go env -w GOINSECURE=.corp.example.com This configuration treats matching modules as private (direct fetch, no proxy/sumdb) and insecure (no TLS).
Citations:
- 1: https://pkg.go.dev/cmd/go
- 2: https://pkg.go.dev/cmd/go@go1.24.2
- 3: https://go.dev/ref/mod
- 4: https://go.dev/issue/37519
GOFLAGS=-insecure is invalid in Go 1.24 and will cause command failures; global * patterns disable all supply-chain protections.
At Line 24, GOFLAGS=-insecure is not a recognized flag in Go 1.24 (the -insecure flag was deprecated in Go 1.14 in favor of GOINSECURE). This will cause command parsing failures at runtime.
At Lines 23–26, using * patterns for GONOSUMCHECK, GONOSUMDB, and GONOPROXY disables checksum validation and proxy protections globally, removing all supply-chain integrity checks. Additionally, GONOSUMCHECK is not a standard Go environment variable.
Replace with scoped patterns using GOPRIVATE (which acts as a default for both GONOSUMDB and GONOPROXY) and GOINSECURE if plain HTTP is required:
-ENV GONOSUMCHECK=*
-ENV GOFLAGS=-insecure
-ENV GONOSUMDB=*
-ENV GONOPROXY=*
-ENV GOPROXY=direct
+# For private modules, scope patterns narrowly:
+# ENV GOPRIVATE=github.com/<org>/*
+# ENV GOINSECURE=github.com/<org>/* (if plain HTTP is required)🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@backend/Dockerfile.dev` around lines 23 - 27, Remove the invalid global
GOFLAGS=-insecure and stop using blanket "*" patterns for GONOSUMCHECK,
GONOSUMDB, and GONOPROXY; instead set GOPRIVATE to the specific private module
path(s) you need (which will scope GONOSUMDB/GONOPROXY behavior) and, only if
required for specific hosts, set GOINSECURE and GOPROXY for those specific
domains (not "*"); update the ENV entries so they use
GOPRIVATE=<your-private-modules> and optionally
GOINSECURE=<comma-separated-hosts> and GOPROXY=<proxy-for-specific-hosts> while
removing GOFLAGS and the global "*" entries.
| // Layout | ||
| import Layout from './components/Layout'; | ||
| import SupportOpenSource from './Pages/SupportOpenSource'; | ||
| // import SupportOpenSource from './Pages/SupportOpenSource'; |
There was a problem hiding this comment.
Disabling /support-debateai route breaks existing navigation paths.
With Line 68 commented, header links pointing to /support-debateai now fall through to the wildcard redirect at Line 108. This creates a silent navigation failure.
🔧 Proposed fix (restore route)
-// import SupportOpenSource from './Pages/SupportOpenSource';
+import SupportOpenSource from './Pages/SupportOpenSource';
...
- {/* <Route path='support-debateai' element={<SupportOpenSource />} /> */}
+ <Route path='support-debateai' element={<SupportOpenSource />} />Also applies to: 68-68
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@frontend/src/App.tsx` at line 20, The commented import and removed route for
the SupportOpenSource component (formerly imported as SupportOpenSource) caused
header links to /support-debateai to fall through to the wildcard redirect;
restore the import for SupportOpenSource and re-add the Route that mounts it at
path "/support-debateai" in the router configuration so header links resolve
correctly (ensure the route is registered before the wildcard Redirect/Route
that handles unknown paths).
|
Hi, I've addressed all the @CodeRabbit review comments and pushed the fixes. Could a maintainer please review this PR when you get a chance? Thank you! |
|
The PR description image shows the updated "Debate Details" modal — the layout looks clean with a single unified scrollbar on the right side, all sections (Debate Summary, Your Performance, and Full Conversation) are visible, and the conversation messages render properly within the scrollable container. The flex-based restructuring is visible in the result.
✅ Actions performedReview triggered.
|
1 participant
🧩Improve Debate Details Modal Layout & Scrolling
Issue Overview
While testing the Profile page, the Debate Details modal had several usability problems that affected readability and navigation:
Some content sections were not fully visible
Scrolling felt inconsistent due to multiple scroll areas
The layout looked tight and visually unbalanced
Long conversations were hard to read properly
What was happening ?
The modal did not properly manage height and overflow. Because of this:
Content exceeded the visible area
Inner elements introduced their own scrollbars
This created a nested scroll experience, which felt broken
🛠️ Changes Made
Reorganized modal structure using flex layout
Limited modal height relative to viewport for better control
Centralized scrolling into one container only
Removed unnecessary overflow rules from inner sections
Improved spacing between sections for better clarity
Adjusted layout to handle long conversation data more gracefully
Outcome
Smooth, single-direction scrolling
Entire content (including Full Conversation) is now accessible
More balanced and readable layout
Better handling of large data inside modal
Impact
Medium – No functional breakage, but significantly improves user experience and readability
Verification
Tested with long conversation data
Checked modal behavior across different screen sizes
Confirmed no overlapping or hidden content
Issue Reference
Close #370
Summary by CodeRabbit
New Features
Chores