Small fix in SF_surfcov_2D plot and mean_MFsurfchem#193
Merged
Conversation
ajnonaka
approved these changes
Aug 29, 2025
ajnonaka
left a comment
ajnonaka
left a comment
Contributor
There was a problem hiding this comment.
Thank you @HyuntaeJung for the PR and catching the 2D condition needed for the surface chemistry structure factor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src_compressible_stag/main_driver.cpp
: There is an error when simulating 3D system with both SF calculation and n_ads_spec>0.
This error is resolved by adding "do_2D &&" at line 1655 (if condition for plt_SF_surfcov_2D).
I fixed it temporarily since (i) it works in my current systems, and (ii) the error only occurs when n_ads_spec>0.
src_MFsurfchem/MFsurfchem_functions.cpp and MFsurfchem_namespace.H
: add mean_MFsurfchem and mean_pressure[m], to compute adsorption and desorption rates with equilibrium values