feat(training): use DCT in PlotSpectrum to compute spectra on regional domains#2
Open
cbovalo wants to merge 9 commits into
Open
feat(training): use DCT in PlotSpectrum to compute spectra on regional domains#2cbovalo wants to merge 9 commits into
cbovalo wants to merge 9 commits into
Conversation
cbovalo
added
enhancement
cbovalo
changed the title
cbovalo
changed the title
There was a problem hiding this comment.
Pull request overview
This PR updates the training diagnostics power-spectrum plotting to automatically choose between spherical-harmonic spectra (SHT) for global-like domains and a DCT-based spectrum computation for regional domains, with accompanying unit tests.
Changes:
- Added a global-coverage heuristic and automatic backend selection (
shtvsdct) inplot_power_spectrum. - Implemented a new DCT-based regional spectrum computation and routed
compute_spectrathrough amethodparameter. - Added unit tests to verify backend auto-selection behavior in the plotting path.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| training/tests/unit/diagnostics/test_plotting_callbacks.py | Adds tests verifying plot_power_spectrum selects SHT/DCT based on detected coverage (plus formatting adjustments). |
| training/src/anemoi/training/diagnostics/plots.py | Implements global-vs-regional detection and adds a DCT-based spectra backend exposed via compute_spectra(..., method=...). |
| training/src/anemoi/training/diagnostics/callbacks/plot.py | Formatting-only adjustments in plotting callback loops and argument wrapping. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cbovalo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the DCT as the way to compute spectra on regional domains.
What problem does this change solve?
Currently, spectra on regional domains are computed using Spherical Harmonic Transforms through the library SHTOOLS. It assumes that the domain is global. Even if this library could be used for arbitrary domains, the DCT is more suited for this task.
What issue or task does this change relate to?
Fixes ecmwf#1055
As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/
By opening this pull request, I affirm that all authors agree to the Contributor License Agreement.