access_test & access_test_component: MPI is not optional#432
Merged
Conversation
harshula
commented
May 29, 2026
Collaborator
- https://github.com/ACCESS-NRI/access-test-component/blob/19cbd388607dc3d1f4d989e1b3b1e3b73445d131/stub/CMakeLists.txt#L11
- We are using ACCESS-TEST to debug Spack concretizer issues, so we need to make sure the SPR is 100% accurate.
aidanheerdegen
approved these changes
May 29, 2026
aidanheerdegen
left a comment
Member
There was a problem hiding this comment.
I can no longer recall the rationale for making MPI optional. If we never use or need that functionality then I agree this is the right approach.
On the other hand if we did need to have a non-MPI version then the CMake build should reflect this. Assuming we don't, I approve these changes.
Collaborator
Author
|
At this stage, we have to make sure that the SPRs accurately represent the current state of https://github.com/ACCESS-NRI/access-test-component/blob/main/stub/CMakeLists.txt . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.