Skip to content

access_test & access_test_component: MPI is not optional#432

Merged
harshula merged 1 commit into
api-v2from
fix-access-test
May 29, 2026
Merged

access_test & access_test_component: MPI is not optional#432
harshula merged 1 commit into
api-v2from
fix-access-test

Conversation

@harshula

Copy link
Copy Markdown
Collaborator

@aidanheerdegen aidanheerdegen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can no longer recall the rationale for making MPI optional. If we never use or need that functionality then I agree this is the right approach.

On the other hand if we did need to have a non-MPI version then the CMake build should reflect this. Assuming we don't, I approve these changes.

@harshula

Copy link
Copy Markdown
Collaborator Author

At this stage, we have to make sure that the SPRs accurately represent the current state of https://github.com/ACCESS-NRI/access-test-component/blob/main/stub/CMakeLists.txt .

@harshula harshula merged commit 6e185aa into api-v2 May 29, 2026
5 checks passed
@harshula harshula deleted the fix-access-test branch May 29, 2026 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants