Split grid function into grid and pseudoenv#17
Open
kaibagley wants to merge 4 commits into
Open
Conversation
Braden-Thorne
requested changes
May 28, 2026
Braden-Thorne
left a comment
Braden-Thorne
left a comment
Contributor
There was a problem hiding this comment.
Outside of the missing parenthesis in the ofe_grid_data() function I see no technical issues, happy to merge once it is fixed.
Does the Roxygen documentation update automatically or does this need to be generated before merging? Curious so I know for the future.
Ps. The evaluation code looks cool!
| dplyr::arrange(Rep, Col, Row), | ||
| original_data = data_out | ||
| ) | ||
| } |
Contributor
There was a problem hiding this comment.
Missing a closing parenthesis here.
Contributor
|
In terms of how I feel about it, I am very happy to see it separated from the gridding function. Ideally I would like to see some better pseudo-environment methods that use other columns of the dataframe to give more informative pseudo-environments, but I think that is a job for the future/another pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Braden, I just split your function into two, where
ofe_grid_data() |> ofe_make_penvs()should be equivalent to your oldofe_grid_data().Pls lemme know how you feel about this change, and if I've done it correctly!
Don't mind all of the evaluation stuff, accidentally committed and merged it all with main so its ugly as fuck and i couldn't be bothered cherry picking or whatever, sorry king!!
Thanks sir