Conversation
1085605 to
ea8e403
Compare
Signed-off-by: Hendrik Wolff <hendrik.wolff@agdsn.me>
|
thanks but this is too expensive as-is, a different approach will be necessary but im not sure what yet, i plan to return to this when i get the chance to, perhaps december or early next yera, it is fine to not rebase this until that time |
|
oh, sorry i didn't want to put pressure on you by rebasing. |
|
Can this be merged? IMHO the implementation is simple and clean, and it will greatly benefit many users. |
|
@hw0lff i have separately worked on PWA support for UI-V1.5 #1453 , maybe you could have a look at implementing folder-level PWA links in there? my implementation comes with web-share target support so it goes a little further with OS integration |
|
@tilse I looked at #1453 just for a few minutes. Back when I wrote this, I couldn't figure out where to properly intercept the web request for the manifest.json so I added the PS/Side note: Only the manifest.json is a hard requirement for a PWA. A service worker is optional and only necessary for additional functionality. |
Announcing a webmanifest makes the website installable as a PWA.
This PR complies with the DCO; https://developercertificate.org/