Skip to content

Add pwa support, allow pwa-ing sub-folders - #749

Open
hw0lff wants to merge 1 commit into
9001:hovudstraumfrom
hw0lff:webmanifest
Open

hw0lff wants to merge 1 commit into
9001:hovudstraumfrom
hw0lff:webmanifest

Conversation

@hw0lff

@hw0lff hw0lff commented Sep 2, 2025

Copy link
Copy Markdown

Announcing a webmanifest makes the website installable as a PWA.

This PR complies with the DCO; https://developercertificate.org/

@hw0lff
hw0lff marked this pull request as draft September 2, 2025 16:42
@hw0lff
hw0lff marked this pull request as ready for review September 2, 2025 16:44
@hw0lff
hw0lff force-pushed the webmanifest branch 2 times, most recently from 1085605 to ea8e403 Compare September 8, 2025 21:30
Signed-off-by: Hendrik Wolff <hendrik.wolff@agdsn.me>
@9001

9001 commented Oct 22, 2025

Copy link
Copy Markdown
Owner

thanks but this is too expensive as-is, a different approach will be necessary but im not sure what yet, i plan to return to this when i get the chance to, perhaps december or early next yera, it is fine to not rebase this until that time

@hw0lff

hw0lff commented Oct 23, 2025

Copy link
Copy Markdown
Author

oh, sorry i didn't want to put pressure on you by rebasing.
I just patch copyparty with this for myself.
I'll just do this on a different branch from now, so that this PR (and you) will not get spammed with the rebases.

@ilotoki0804

Copy link
Copy Markdown
Contributor

Can this be merged? IMHO the implementation is simple and clean, and it will greatly benefit many users.

@tilse

tilse commented Jul 20, 2026

Copy link
Copy Markdown

@hw0lff i have separately worked on PWA support for UI-V1.5 #1453 , maybe you could have a look at implementing folder-level PWA links in there? my implementation comes with web-share target support so it goes a little further with OS integration
i'd also suggest inverting the argument logic, because imo PWAs should be supported by default

@hw0lff

hw0lff commented Jul 27, 2026

Copy link
Copy Markdown
Author

@tilse I looked at #1453 just for a few minutes.
From what I can see, the manifest.json is currently a static file there.
In my current implementation it is generated dynamically.
In my understanding of copypartys code, it needs to be generated at request time to set the start_url parameter correctly.

Back when I wrote this, I couldn't figure out where to properly intercept the web request for the manifest.json so I added the ?pwa URL parameter as a workaround.

PS/Side note: Only the manifest.json is a hard requirement for a PWA. A service worker is optional and only necessary for additional functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants