Skip to content

⚡ Bolt: Memoize WBGraph component #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
google-labs-jules wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

⚡ Bolt: Memoize WBGraph component #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 9 additions & 19 deletions components/WBGraph.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
"use client";

import { memo } from "react";
import {
ScatterChart,
Scatter,
Expand All @@ -9,7 +10,6 @@ import {
Tooltip,
ResponsiveContainer,
ReferenceLine,
Label,
} from "recharts";
import { EnvelopePoint } from "../data/aircraft";

Expand All @@ -22,21 +22,21 @@ interface WBGraphProps {
isDark: boolean;
}

const RenderTakeoffPoint = (props: any) => {
const RenderTakeoffPoint = (props: { cx: number; cy: number }) => {
const { cx, cy } = props;
return (
<circle cx={cx} cy={cy} r={6} fill="#dc2626" stroke="white" strokeWidth={2} cursor="pointer" />
);
};

const RenderLandingPoint = (props: any) => {
const RenderLandingPoint = (props: { cx: number; cy: number }) => {
const { cx, cy } = props;
return (
<circle cx={cx} cy={cy} r={6} fill="#16a34a" stroke="white" strokeWidth={2} cursor="pointer" />
);
};

export default function WBGraph({ envelope, takeoffWeight, takeoffCG, landingWeight, landingCG, isDark }: WBGraphProps) {
function WBGraph({ envelope, takeoffWeight, takeoffCG, landingWeight, landingCG, isDark }: WBGraphProps) {
const takeoffPoint = [{ cg: takeoffCG, weight: takeoffWeight }];
const landingPoint = landingWeight ? [{ cg: landingCG, weight: landingWeight }] : [];

Expand Down Expand Up @@ -72,13 +72,7 @@ export default function WBGraph({ envelope, takeoffWeight, takeoffCG, landingWei
stroke={axisColor}
tick={{ fill: axisColor, fontSize: 12 }}
>
{/* <Label
value="Center of Gravity (inches)"
offset={0}
position="insideBottom"
fill={axisColor}
style={{ fontSize: '12px', fontWeight: 'bold' }}
/> */}
{/* Labels removed for cleaner mobile look */}
</XAxis>

<YAxis
Expand All @@ -90,13 +84,6 @@ export default function WBGraph({ envelope, takeoffWeight, takeoffCG, landingWei
stroke={axisColor}
tick={{ fill: axisColor, fontSize: 12 }}
>
{/* <Label
value="Weight (lbs)"
angle={-90}
position="insideLeft"
fill={axisColor}
style={{ textAnchor: 'middle', fontSize: '12px', fontWeight: 'bold' }}
/> */}
</YAxis>

<Tooltip
Expand Down Expand Up @@ -164,4 +151,7 @@ export default function WBGraph({ envelope, takeoffWeight, takeoffCG, landingWei
</div>
</div>
);
}
}

// Optimization: Memoize graph to avoid expensive Recharts re-renders on unrelated UI toggles (like "Moments" or "Config")
export default memo(WBGraph);
Loading