Migrate to Ember 7.3 with Vite/Embroider and pnpm - #320
Merged
Merged
Conversation
Nobody's using it in dev, and it's not needed for prod (just static files)
silverbucket
self-requested a review
September 24, 2026 16:46
silverbucket
approved these changes
Sep 24, 2026
silverbucket
left a comment
Member
There was a problem hiding this comment.
Started up and ran without any issues, LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves Hyperchannel off the classic Broccoli build (Ember 6.4 + npm) onto Ember 7.3 with Vite/Embroider and pnpm, replaces the addons removed or deprecated in Ember 7, and fixes the regressions surfaced while validating the migration. A handful of Sockethub/messaging bug fixes and a modal accessibility pass are included.
Build & tooling
ember-cli-build.jswithember-cli-build.mjs(
@embroider/compatcompatBuild+@embroider/vitebuildOnce).vite.config.mjs,babel.config.mjs,postcss.config.mjs, rootindex.html(moved fromapp/index.html),testem.cjs(fromtestem.js),and
app/config/environment.js(via@embroider/config-meta-loader).app/app.jsusesResolver.withModules(compatModules);app/router.jsuses
@embroider/router.>= 20.19.0.pnpm/action-setup@v4withsetup-node'scache: pnpmand
--frozen-lockfile.Package manager: npm → pnpm
"packageManager": "pnpm@10.32.1"; removedpackage-lock.json,added
pnpm-lock.yaml.pnpm run;README.md/AGENTS.mdupdated.pnpm.ignoredBuiltDependencies: ["@parcel/watcher"]documents that itsinstall script is intentionally skipped (prebuilt binary is used).
Dockerfilerather than porting it.Styling
app.scssimported fromapp.js); Tailwind v3 + autoprefixervia
postcss.config.mjs; removedember-cli-postcss,@csstools/postcss-sassandpostcss-scss.Dependencies replaced / removed
ember-promise-modals→ localmodalsservice +ModalOverlay.ember-concurrency→ guarded async action (single usage).ember-lifeline→ nativesetTimeout/requestAnimationFramewithdestroy guards.
ember-keyboard-shortcuts→shortcut-matchesutil + rewrittenkeyboard-shortcutsmodifier.consistent-color-generation(js-sha1, whoseeval("require('crypto')")tripped Rolldown's
[EVAL]warning) →app/utils/user-color.js(XEP-0392 via
@noble/hashes+hsluv); output unchanged.@ember/render-modifiers, ember-auto-import, loader.js, stylelint, webpack,
etc.); upgraded
ember-autofocus-modifier,ember-truth-helpers,tracked-built-ins,ember-moment,@ember/test-waiters.Embroider compatibility
{{component ...}}with static components inadd-chat-account.hbs,channel-container.hbsandjoin-channel.hbs.user-colortolerates missing identifiers so a malformed nickname can'tabort a render; restored the
date-headlinebranch.Bug fixes
user-channel-idutil;firstObject→
[0]and empty-channel guards across routes/components.serverwhen matching thehostname.
leave: stopped sending the invalid emptyobject: {}(rejectedby Sockethub's
oneOfschema) and added the leave error callback.Modal accessibility
focus-trapmodifier: focuses dialog content on open (first Tab →"Add"), traps Tab/Shift+Tab, closes on Escape, restores focus on close.
role="dialog",aria-modal,aria-label; background ismade
inertwhile open.Tests / docs
tests/index.html+test-helper.json the new blueprint; testem runsagainst
distaftervite build --mode development.longer resolves under Embroider).
Test plan
pnpm test→ 150 tests: 147 pass, 3 skip, 0 failpnpm lint(JS, HBS, format) → cleanpnpm build,pnpm build-prod,pnpm start→ succeedNotes / follow-ups
docs/UPGRADE_SUMMARY.mddocuments the full migration.