Skip to content

fix: sanitize subprocess call in simulation_runner.py#592

Open
orbisai0security wants to merge 1 commit into
666ghj:mainfrom
orbisai0security:fix-v-001-backend-app-services-simulation-runner.py
Open

fix: sanitize subprocess call in simulation_runner.py#592
orbisai0security wants to merge 1 commit into
666ghj:mainfrom
orbisai0security:fix-v-001-backend-app-services-simulation-runner.py

Conversation

@orbisai0security
Copy link
Copy Markdown

Summary

Fix critical severity security issue in backend/app/services/simulation_runner.py.

Vulnerability

Field Value
ID V-001
Severity CRITICAL
Scanner multi_agent_ai
Rule V-001
File backend/app/services/simulation_runner.py:438

Description: The simulation runner spawns OS subprocesses via subprocess.Popen at line 438. User-controlled parameters from the simulation API (entity_types_str at simulation.py:66, project_id at simulation.py:797) flow into the simulation execution pipeline without confirmed sanitization. If these values are incorporated into subprocess command arguments using string concatenation or with shell=True, an attacker can inject shell metacharacters to execute arbitrary operating system commands on the server.

Changes

  • backend/app/services/simulation_runner.py
  • backend/pyproject.toml

Verification

  • Build passes
  • Scanner re-scan confirms fix
  • LLM code review passed

Automated security fix by OrbisAI Security

The simulation runner spawns OS subprocesses via subprocess
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant