Conversation
- bug_report exit-3 hint no longer says the site challenges nobody (the README retracted that: 8 of 10 datacentre requests met AWS WAF); it points at tools/waf_probe.sh and the products section instead. - SECURITY.md: no longer claims the project has no releases. - README: family access badge, "runs without an account if AWS WAF passes your IP", linked to the products section. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
bug_report.ymlexit-3 hint said "This repo's own research found no captcha, proxy or browser challenge anywhere on this site from a plain datacentre fetch ... exit 3 here usually means something upstream really changed, not that a proxy or--twocaptcha-keyis missing". The README retracted exactly that ("Corrected in v0.4.1": 8 of 10 consecutive datacentre requests got an AWS WAF captcha). The hint now points attools/waf_probe.shand "What the 2Captcha products are for here".SECURITY.mdsaid "no releases or version tags"; v1.0.0/v1.1.0 exist.Added
runs without an account · if AWS WAF passes your IP, linked to the products section. The README's own measurement is that the challenge depends on the address on the day, so a plain "runs without an account" would overclaim and "needs the Scraping Browser API" would underclaim.Kept, deliberately
The ~30
mediamarkt-scrapermentions all name it as a sibling and state a lesson or a provenance: "Ported from this family's mediamarkt-scraper", "same convention as this family's mediamarkt-scraper", "the way MediaMarkt runs one platform across ten", themediamarkt.lulesson, "NOT required the way mediamarkt-scraper's equivalent flag is", the canary's "A sibling in this family (mediamarkt-scraper) gates its canary...". None describes MediaMarkt as if it were Transfermarkt. Also kept: tokopedia/catawiki/etsy/farfetch/amazon provenance notes,"datadome"in generic vendor lists, CHANGELOG released sections,tools/(all three are Transfermarkt-specific:TRANSFERMARKT_*env vars, transfermarkt.com URLs).Borderline, kept:
diff_runs.py/output_writer.pydocstrings that say "See mediamarkt-scraper's ... for the full rationale". They name the sibling and describe nothing wrongly; they do send the reader to another repo for the reasoning.Repo metadata unchanged (description and topics are Transfermarkt's;
price-monitoringis arguable for market values, left alone).Suite: 545 PASS, OK before and after (engine groups skipped, engines absent).
ci_checks.py --secret-check --help-check --sample-checkgreen.🤖 Generated with Claude Code