ci: check rendered links on pull requests#601
Open
Haleshot wants to merge 8 commits into
Open
Conversation
…le source of truth?) instead of being b/w nox and CI
Haleshot
commented
Apr 21, 2026
Haleshot
commented
Apr 21, 2026
| - name: Link Checker (internal, offline) | ||
| uses: lycheeverse/lychee-action@v2.7.0 | ||
| with: | ||
| args: --offline --no-progress --root-dir "${{ github.workspace }}/public" --exclude '^file://.*/public/roadmap/?$' public/**/*.html |
Contributor
Author
There was a problem hiding this comment.
I hesitated a bit over hardcoding this but I feel it makes sense. /roadmap is intentionally served from the separate roadmap repo rather than from this site build (as noted here). This exclude is only here to stop the PR check from treating it as a missing local file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #599, I had a closer look at the link-checking setup to see if breakage could be caught earlier.
First looked at whether it made sense to run
lycheedirectly on source Markdown, but for this repo that seems to be the wrong level to validate. Hugo resolves and renders links in ways that make source-level checking much noisier than it looks.This changes CI so built HTML is also checked on pull requests, which should catch the same class of internal-link regression before merge.
I also folded the shared lychee settings into lychee.toml so the local and CI behavior stays in sync.
Ahh, sorry, I hadn’t synced my remote fork correctly, so a some unrelated commits got pulled into this PR.
CC: @choldgraf