Repository navigation
ci: run gate-assertion self-test in the rust job - #385
Conversation
tools/test_assert_gate_ran.sh exercises assert-gate-ran.sh's fail-closed branch, whose regression mode is a green job rather than visible bad output; no workflow invoked it. Run it in the rust job right after checkout (ubuntu leg only) so a regressed helper fails in ~1 s, before the build, in the same job as the call sites it guards. Also correct tools/README.md: the helper now backs six validation gates, not five, and the self-test's Used by cell is CI (ci.yml), not Local. Closes #373
|
PR #385's |
|
✅ Approved! A tight, well-scoped CI change: one new step plus two stale doc cells, 8 additions / 2 deletions. Every claim in the PR body was re-derived rather than taken on trust; all of them hold. VerificationStep placement and shape (
The "six gates" doc correction is accurate.
Local run (worktree Table integrity: Issue linking: AC4 — live verification performed (the one the PR deferred to me)Read from this PR's own CI run 43664888110 at head
AC4 is satisfied. Every other AC verified above. Recorded separately with a CI and merge state
Test plan execution
Notes (non-blocking, nothing to track)
|
|
AC4 live verification performed (Judge). Issue #373's acceptance criterion AC4 required confirming, from this PR's own CI run, that the new What was run: read run What was observed:
AC4 is satisfied at this tree. |
|
PR #385's |
|
Champion Auto-Merge This PR meets all safety criteria for automatic merging:
Proceeding with merge... If this was merged in error, you can revert with: Automated by Champion role |
Summary
tools/assert-gate-ran.shis the single assertion standing between a silently-skipped validation gate and a greenrustjob (six call sites inci.yml). Its fail-closed branch — the one whose regression mode is a green job rather than visible bad output — was exercised only bytools/test_assert_gate_ran.sh, which no workflow invoked (git grep test_assert_gate_ran -- .github/returned nothing onorigin/main@02207bf). This PR wires that self-test into therustjob and corrects the two staletools/README.mdcells for the helper and its self-test.Closes #373
Changes
.github/workflows/ci.yml(rustjob): one new stepgate-assertion self-testrunning./tools/test_assert_gate_ran.sh, immediately afteractions/checkout@v4and before the toolchain setup / firstassert-gate-ran.shcall site, guarded withif: matrix.os == 'ubuntu-latest'(the job is a three-leg matrix). Plainrun:— no|| true, nocontinue-on-error, noif: always(). Needs only a checkout, so a regressed helper fails in ~1 s instead of behind the build.tools/README.md:assert-gate-ran.sh's "Used by" cell now reads "all six validation gates" (the sixth,REFINEMENT GATE PASSED, arrived via test(validation): bound the engine's own refinement error at 1 THz #363/ci: assert every validation gate ran through one helper, drop the SKIPPED greps #367 while the prose said five), andtest_assert_gate_ran.sh's cell now readsCI (ci.yml)instead ofLocal.Acceptance Criteria Verification
./tools/test_assert_gate_ran.sh, in therustjob, before the firstassert-gate-ran.shcall site, carryingif: matrix.os == 'ubuntu-latest'. Verified by reading the diff: onegrep -c 'test_assert_gate_ran'match in the file, positioned after checkout (line 165) and before the toolchain step; first call site now at line ~208.git grep -n 'test_assert_gate_ran' -- .github/returns one match (returned none onorigin/main).run:step;grep -n 'continue-on-error\||| true'overci.ymlreturns nothing.Rust (ubuntu-latest)job log requires the CI run this PR itself triggers. Offline evidence attached below covers the same assertions locally; it does NOT establish the CI log content. Judge: please confirm the step printsall assert-gate-ran.sh cases passedand the log contains noSKIP unreadable log fails closedline in this PR's run.tools/README.mdtest_assert_gate_ran.sh"Used by" cell readsCI (ci.yml).tools/README.mdassert-gate-ran.shcell reads "all six validation gates".Test Plan
python3 -c "import yaml; yaml.safe_load(open('.github/workflows/ci.yml'))"— OK../tools/test_assert_gate_ran.shin the worktree (non-rootubuntuuser, matching the GitHub-hostedrunneruser): printsall assert-gate-ran.sh cases passed, exit 0, < 1 s, with noSKIP unreadable log fails closedline — i.e. the unreadable-log fail-closed case ran, not skipped.git status --porcelainempty afterwards (the test writes only into$(mktemp -d)).git diff --statshows only.github/workflows/ci.ymlandtools/README.md;docs/validation.mduntouched (it carries no numeric count and was already correct per the issue's Out of Scope).Live verification NOT performed for AC4 (the CI log of this PR's own run) — tracked by this PR itself; no separate tracking issue needed.
TDD: not applicable — the behavior under test already exists (
test_assert_gate_ran.shships onmain); this change only invokes it from CI, and the red-first demonstration is the issue's mutant run (fail-closed guard removed →missing log is not a zero countexits 0).loom dashboard