Repository navigation
refactor: read contact_rect_values' centre and widths via equiv_rect_values - #382
Conversation
…values contact_rect_values re-implemented equiv_rect_values' centre-and-widths parse line for line, including a byte-identical user-facing width error. It now calls equiv_rect_values over the same leading values, completing the documented 5 -> 7 -> 9 delegation chain (decay_rect_values already layered on contact_rect_values the same way). A clause malformed in both a width and a cell behind it now reports the structurally prior field (the width) first; contact_rect_arity_and_ parameter_errors pins that order. Closes #377
|
PR #382's |
|
✅ Approved! A clean, minimal completion of the documented 5 → 7 → 9 delegation chain. The one behavioural consequence is taken deliberately and pinned by a test I falsified myself. Spec reconciliationReviewed against #377's current body. Its only two comments are the Champion promotion and the Builder's lease record — no rescoping, no operator ruling. The PR's acceptance-criteria table maps one-for-one onto the issue's Proposed Approach 1–4, and no material difference between the current requirements and this PR's scope exists. Correctness
TDD claim: verified, not path-matched
VERIFIED — it fails at the base for precisely the reason the change addresses (the old axis-0-completes-first order reporting Worktree restored to Test ExecutionTest plan from the PR description:
Merge state Two observations — decided, not deferred1. The deleted hunk carried the codebase's only copy of a rationale comment. Measured: 2. Description nit (no change requested): the "net −5 lines" in the first Changes bullet is the file-level net (14 deletions − 9 insertions), not the function's. The function body alone is −13 ( |
|
PR #382's |
|
Champion Auto-Merge This PR meets all safety criteria for automatic merging:
Proceeding with merge... If this was merged in error, you can revert with: Automated by Champion role |
Summary
contact_rect_valuesre-implementedequiv_rect_values' centre-and-widths parse line for line — including a byte-identical user-facing width error. It now callsequiv_rect_valuesover the same leading values, completing the documented 5 → 7 → 9 delegation chain (decay_rect_valuesalready layered oncontact_rect_valuesthe same way).Changes
contact_rect_values(fasterhenry-cli/src/inp.rs): replaced thetriplecall and the width half of its axis loop withlet (centre, widths) = equiv_rect_values(values, what, unit, line)?;— the loop keeps only the cell parse, thecompatclamp and the cell rejection (net −5 lines; the duplicated width error string is gone).contact_rect_arity_and_parameter_errors: new casecontact rect (5, 3, 0, 2, -1, 2, 1)pinning the deliberate error-order change — a clause malformed in both a width and a cell behind it now reports the structurally prior field (ywidth) first, where it previously reportedxcell.Acceptance Criteria Verification
equiv_rect_valuescall; keep the cell parse, compat clamp and cell rejection in the loopgit diffshows exactly that;cargo check -p fasterhenry-clicompilescontact_rect_arity_and_parameter_errorsfasterhenry-cli/src/inp.rs:5872-5879; verified it fails on the pre-change code (reportsxcell=0.002, expectedywidth=-0.001) and passes after:5879,:5883,:6994,:6998pass unchangedcargo test -p fasterhenry-cli— all pass, unmodifiedequiv_rect_values' signature unchangedfasterhenry-cli/src/inp.rs, one function body + the pinning testTest Plan
cargo test -p fasterhenry-cli— 161 + 20 + 6 + 22 passed, 0 failed (includescontact_rect_arity_and_parameter_errors,decay_rect_parameter_errors,equiv_rect_and_connection_parameter_errors).cargo fmt --all --checkclean;cargo clippy --workspace --all-targets -- -D warningsclean (both CI commands verbatim).Closes #377
loom dashboard