feat(antminer): add missing trait implementations for stock AM#274
feat(antminer): add missing trait implementations for stock AM#274b-rowan wants to merge 4 commits into
Conversation
| }; | ||
|
|
||
| self.web | ||
| .set_miner_conf(json!({ mode_key: mode.to_string() })) |
There was a problem hiding this comment.
does this need to be merged with the existing configuration?
There was a problem hiding this comment.
I don't think so for 2023? I don't have a miner with newer FW so I can't really test, but the pause/resume implementation seems to not care -
| let success = self.web.change_password(password).await?; | ||
| if success { | ||
| let username = self.web.username().to_string(); | ||
| self.set_auth(MinerAuth::new(username, password)); |
There was a problem hiding this comment.
the call could time out after the miner accepted the password change and the would leave us with stale creds. Maybe we should re auth after the change_password call to verify what creds are set.
There was a problem hiding this comment.
Good idea. That endpoint is kinda slow (same as everything on stock IG)...
ankitgoswami
left a comment
ankitgoswami
left a comment
There was a problem hiding this comment.
❤️ left a few comments but mostly looks good. Can't wait to try it on fleet!
|
Ill look at the re-auth idea, its probably not a bad idea to try to deal with those funky edge cases. |
2 participants
Adds all traits that stock antminer firmware can support, basically everything sans scaling.
Includes some generic fixes for python representations of data types I noticed while testing.