Modify sig_uv calculation by removing scaling factor#58
Modify sig_uv calculation by removing scaling factor#58YilongZhang-Cosmo wants to merge 2 commits into
Conversation
YilongZhang-Cosmo
force-pushed
the
better_lc_noise
branch
from
debce2a to
02c2950
Compare
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
View / edit / reply to this conversation on ReviewNB DanielaBreitman commented on 2025-11-26T15:51:53Z Why can't we just import this function from tuesday? |
|
View / edit / reply to this conversation on ReviewNB DanielaBreitman commented on 2025-11-26T15:51:54Z Line #2. #uv_coverage = np.zeros((lc_shape[0],lc_shape[0],len(freqs)))#Nu, Nv, Nfreqs Just delete this. |
|
View / edit / reply to this conversation on ReviewNB DanielaBreitman commented on 2025-11-26T15:51:54Z No need to keep this I think.
|
|
View / edit / reply to this conversation on ReviewNB DanielaBreitman commented on 2025-11-26T15:51:55Z This also maybe no need to have. |
|
View / edit / reply to this conversation on ReviewNB DanielaBreitman commented on 2025-11-26T15:51:56Z Also no need to have this. |
|
View / edit / reply to this conversation on ReviewNB steven-murray commented on 2025-11-28T01:04:15Z Please make the bandwidth a reasonable number like 8 MHz |
|
View / edit / reply to this conversation on ReviewNB steven-murray commented on 2025-11-28T01:04:16Z Why did this change so much? |
|
View / edit / reply to this conversation on ReviewNB steven-murray commented on 2025-11-28T01:04:17Z You can have a look at my new noteboook on the better_lc_noise branch -- I pass in the sigma_uv as weights here. |
|
Closing this in favour of the changes as made in #49 |
2 participants
Removed unnecessary scaling factor of 1e6 from the calculation of sig_uv.