Repository navigation
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Resolve native tools from the loaded Windows system and PowerShell runtime, reject forged roots, and require packaged/native runtime gates for both distributions.
Keep the forged-root authority gate intact and compare it with a baseline child, recording only bounded stage and status facts.
Keep every Windows authority gate intact while distinguishing process startup, module load, resolver, and PowerShell failures without printing raw stderr or diagnostic reports.
Collaborator
Author
|
CONTROL REVIEW OF RECORD — TECHNICAL ACCEPTANCE PASS / MERGE PENDING REQUIRED APPROVAL
Control will use an expected-head guarded merge only after that independent repository approval exists. No tag, release, or deployment is authorized by this review record. Live Setup/Portable support receipts remain a separate runtime-verification item and are not claimed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 6.4.0, a failed or empty Windows tool probe after Fix now could become seven false missing-tool errors in both Setup and Portable. Preflight now requires a successful process result and a complete inventory. A failed check produces one explanation with retry and Support Report actions; genuinely missing tools share one blocker. The reported PC's exact environmental trigger remains unproven without its runtime log.
Repair and elevation use allowlisted absolute Windows system paths. Repair PowerShell reads UTF-8 source through stdin, keeping dynamic scripts and helper passwords out of PowerShell arguments and temporary script files. Failed or timed-out results cannot establish administrator status, successful relaunch, or a running Secondary Logon service. Process handling also preserves Unicode and completes once.
The three support forms use one explicit anonymous HTTPS submission, show Sent only after a valid acknowledgement, and retain drafts for manual retry. Support server code and its Postgres CI job move out of this repository. Release packaging now requires a verified stateless support endpoint. This prepares version 6.4.1; it does not publish a release.
Validation:
npm testcompleted successfully, including 98 tool-resolution checks, 108 preflight checks, 23 process checks, 84 desktop submission checks, and elevation, endpoint-readiness, and checksum regression coverage.Safety impact
This touches safety-sensitive code. A real code-owner review is required by CONTRIBUTING.md; the administrative review exception does not apply.
Release dependency
The support source is merged in support PR #1. Support issue #2 tracks the private bot handoff and live release proof. No Windows tag or release will be published until that endpoint and all three form journeys pass for both packages.
Verification
Review exception
Not applicable: safety-impact changes require code-owner approval.