Add error reporting for invalid credentials and move google service account b64 to plug config#40
Open
shivankacker wants to merge 3 commits into
Open
Add error reporting for invalid credentials and move google service account b64 to plug config#40shivankacker wants to merge 3 commits into
shivankacker wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves configuration and failure visibility for the Google GenAI/Vertex AI scribe provider by moving the Google service-account base64 credential into plugin settings and surfacing clearer initialization errors in the scribe processing task.
Changes:
- Read Google service-account credentials from
plugin_settingsinstead ofos.getenv, with explicit error messages for base64/JSON/key parsing failures. - Wrap AI client initialization in
process_ai_form_fillwith error capture that marks the scribe as failed and records the error inform.meta.processings. - Add
SCRIBE_GOOGLE_APPLICATION_CREDENTIALS_B64to plugin settings defaults.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
care_scribe/tasks/scribe.py |
Adds robust credential decoding/parsing errors and persists AI-client init failures into scribe processing metadata. |
care_scribe/settings.py |
Adds a default config entry for SCRIBE_GOOGLE_APPLICATION_CREDENTIALS_B64 so it can be provided via plugin config/env. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.