Address comparison and attestation fix by ScreamingHawk · Pull Request #750 · 0xsequence/sequence.js

ScreamingHawk · 2025-05-08T00:55:17Z

Prefer Address.isEqual when comparing addresses
Rename Signers.Session.SignerInterface to Signers.Session.SessionSigner
Fix attestation encoding (wasn't hashing strings)
Fix relayer opt type (didn't support functions)
Allow ready or actionable identity signers for session tests
Ensure nitro signers return a checksum address as the identity instrument requires thi

ScreamingHawk added 7 commits May 8, 2025 08:50

Rename session signer interface

604d231

Support promisable address for session signer

16f6c11

Fix attestation encoding

5cad974

Fix relayer opt type

2ede1a0

Identity signer can be ready or actionable

9fdd05d

Use Address.isEqual for address comparison

ede9b5a

Nitro expects addresses as checksum

6d88036

ScreamingHawk requested review from a team as code owners May 8, 2025 00:55

ScreamingHawk merged commit 6b719f8 into master May 8, 2025
3 checks passed

ScreamingHawk deleted the sessions-identity branch May 8, 2025 02:11

Provide feedback