Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issues with the wallet login and logout flows by updating tests and related logic, including fixing witness execution, updating signer status expectations, and refining configuration for Ethereum mocking and DB handling.
- Updated wallet tests to use the "actionable" status instead of "ready" for mnemonic signers.
- Introduced a witness call in the device creation flow.
- Adjusted cron job implementation and migrated relayer configuration to a function.
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/wallet/wdk/test/wallets.test.ts | Added and updated wallet login/logout tests to reflect signer status and witness behavior. |
| packages/wallet/wdk/test/setup.ts | Updated Ethereum mocking to use LOCAL_RPC_URL. |
| packages/wallet/wdk/test/sessions.test.ts | Updated signer status checks in session tests. |
| packages/wallet/wdk/test/recovery.test.ts | Removed hard-coded network configuration from recovery tests. |
| packages/wallet/wdk/test/constants.ts | Added newManager and configuration defaults for test isolation. |
| packages/wallet/wdk/src/sequence/wallets.ts | Added witness invocation for device registration. |
| packages/wallet/wdk/src/sequence/manager.ts | Changed relayers configuration to a function and added DB-stop logic. |
| packages/wallet/wdk/src/sequence/handlers/mnemonic.ts | Updated mnemonic handler return type and status. |
| packages/wallet/wdk/src/sequence/cron.ts | Refactored cron jobs to handle graceful stopping and chaining properly. |
| packages/wallet/wdk/src/dbs/generic.ts | Added a close method for DB cleanup. |
| README.md | Updated the testing instructions regarding anvil and forge requirements. |
Files not reviewed (1)
- package.json: Language not supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.