fix: local docker build#2351
Merged
Merged
Conversation
For setups where only `podman` is available.
Our `Dockerfile` now actually depends on the docker-file-mtimes.tsv file being present. It's however only generated by the Docker build CI workflow, so local builds were just failing. This change adds a Makefile target for generating that build pre-requisite.
Mirko-von-Leipzig
approved these changes
Jul 16, 2026
Restoring last-commit mtimes can only make sources look older than the artifacts in the shared /app/target cache mount, so Cargo's mtime-based freshness check can never detect content that diverges from whatever branch last wrote the cache. This caused CI to link a stale miden-node-utils rlib (built by PR #2350, which added max_connection_age_grace) against pre-#2350 sources, failing with E0063 — and the same mechanism could just as silently ship wrong code that happens to still typecheck. Instead, touch all sources to build time inside the Dockerfile so every workspace path crate is always rebuilt. External dependencies are fingerprinted by checksum, so the cargo-chef dependency cache is unaffected. This removes the docker-file-mtimes.tsv generation from the Makefile and workflows, and the fetch-depth: 0 that existed only to compute it in build-docker.yml. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
sergerad
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Our
Dockerfilenow actually depends on the docker-file-mtimes.tsv file being present. It's however only generated by the Docker build CI workflow, so local builds were just failing.This change adds a Makefile target for generating that build pre-requisite.
This PR also makes the
dockercommand configurable so that it can be overridden for setups with Podman.Changelog